Commit Graph

2665 Commits

Author SHA1 Message Date
Hadrien Milano
b4f65f7aa1 fix wrong test: collection.model must be a function 2015-01-22 17:38:08 -05:00
Graeme Yeates
b93030b0d8 Use matches in .where 2015-01-22 17:38:08 -05:00
Hadrien Milano
5025d3ce71 fix flawed test 2015-01-22 17:38:08 -05:00
Brian Iversen
cd15abfd43 Update backbone.js comment for clarity
Fixed comment in backbone.js
2015-01-22 17:38:08 -05:00
Nick Stefan
d54a8a4901 removed the strong tags, but kept the "with" on 14 2015-01-22 17:38:07 -05:00
Nick Stefan
028fc59eb8 Update README to better match backbonejs.org
line 14 readme missing the word "with":
Backbone supplies structure to JavaScript-heavy applications by providing models key-value binding and custom events, collections...
--> on backbonejs.org reads as -->
Backbone.js gives structure to web applications by providing models with key-value binding and custom events, collections...

Also bolded models, views and collections just as they are on backbonejs.org
2015-01-22 17:38:07 -05:00
JD Isaacks
7e4f140072 Set correct number of assertions 2015-01-22 17:38:07 -05:00
JD Isaacks
63790cd1d6 Add test for negative indexes in at method 2015-01-22 17:38:07 -05:00
JD Isaacks
325a50f2bb Allow Collection.at to accept negative indexes
This allows you to do things like

```javascript
mycollection.at(-2) // get second to last, etc.
```
2015-01-22 17:38:07 -05:00
Adam Krebs
7554b2f01b draft changelog for backbone 1.2.0 2014-09-25 15:46:39 -04:00
Jeremy Ashkenas
c349965312 Merge pull request #3301 from AndrewEastwood/patch-1
Enhancing Model with isEmpty function
2014-09-23 15:37:45 -04:00
Adam Krebs
b966584356 Merge pull request #3039 from fastest963/master
Send correct 'at' when firing 'add' event
2014-09-11 13:45:42 -04:00
James Hartig
34e1a1e40c Send correct 'at' when firing 'add' event 2014-09-11 13:04:36 -04:00
Adam Krebs
fa69c207cd Merge pull request #3265 from tomascasas/bb-col-doc-update
Collection docs: models is not optional if options is passed in
2014-09-11 11:29:38 -04:00
Andrew Ivaskevych
a1b7ac32eb Adding the isEmpty function into the modelMethods 2014-09-09 18:03:55 +03:00
Andrew Ivaskevych
e6fa0e2aaa Enhancing Model with isEmpty function 2014-09-09 16:47:52 +03:00
Brad Dunbar
1dbe3ddf2f Merge pull request #3152 from braddunbar/ie6
Handle incorrect hash/search values in IE6.
2014-08-18 16:53:23 -04:00
Tomas Casas
7a20f16b93 Collection docs: models is not optional if options is passed in 2014-08-13 19:35:46 -03:00
Adam Krebs
6a82b0c897 Merge pull request #3259 from megawac/patch-1
Allow MDN to select an appropriate localization [ci-skip]
2014-08-06 12:50:13 -04:00
Graeme Yeates
fc6b2a6030 Allow MDN to select an appropriate localization 2014-08-06 11:05:16 -04:00
Adam Krebs
56fbfc19db Merge pull request #3258 from NotBobTheBuilder/master
Update JavaScript toJSON API documentation URL
2014-08-06 11:00:41 -04:00
Jack Wearden
4b38a61bbe Update JavaScript toJSON API documentation URL
The previous link to MDN had rotted, this seems to be the closest correct URL.
2014-08-06 15:56:51 +01:00
Jeremy Ashkenas
f2612a92df Merge pull request #3222 from emorikawa/master
Prevent memory leak by `stopListening` on Backbone.Model `destroy`
2014-08-04 17:31:30 -04:00
Jeremy Ashkenas
f7cc792bdc Merge pull request #3236 from akre54/save-and-patch-diff-attrs
Allow Model#save with patch: true to take different attrs
2014-08-04 15:39:40 -04:00
Adam Krebs
0770ab45bb Merge pull request #3240 from HHSnopek/master
add example to Backbone.$ for commonjs
2014-07-24 15:21:43 -04:00
Henry Snopek
0538fc724b add example to Backbone.$ for commonjs 2014-07-24 15:19:19 -04:00
Sam Breed
f59e37eeb2 Merge pull request #3239 from akre54/document-patch
document patch
2014-07-24 12:18:50 -06:00
Adam Krebs
937fa5390d document patch 2014-07-24 13:54:45 -04:00
Adam Krebs
ac384b2c1e test for attributes set on the model correctly in patch save 2014-07-23 11:38:36 -04:00
Adam Krebs
2deb84a982 allow Model#save with patch: true to take different attrs. Fixes #3232 2014-07-23 09:47:29 -04:00
Adam Krebs
4e02c9ad09 Merge pull request #3234 from go-oleg/master
Docs: Fix URL to MDN's JSON.stringify() toJSON behavior
2014-07-22 23:00:14 -04:00
Oleg Seletsky
749c47763b Docs: Remove localization from URL to MDN's JSON.stringify() 2014-07-22 17:37:56 -07:00
Oleg Seletsky
428ff7d507 Docs: Fix URL to MDN's JSON.stringify() toJSON behavior 2014-07-22 15:55:41 -07:00
Evan Morikawa
028a066780 Cleanup event listeners on destroy
When a Model is destroyed, it may still be listening to events.
We should `stopListening` to those events to prevent memory leaks.
2014-07-14 16:33:23 -04:00
Adam Krebs
bc59f5338c Merge pull request #3220 from megawac/rawgit-docs
Use rawgit for linking to old versions of docs
2014-07-14 11:53:52 -04:00
Graeme Yeates
4584124ace Use rawgit for linking to old versions of docs 2014-07-14 11:47:41 -04:00
Adam Krebs
628590bac0 _setElement no longer takes in attributes, update the corresponding comment 2014-07-08 14:36:13 -04:00
Adam Krebs
3b34bf7558 Merge pull request #3214 from austentalbot/patch-1
Switch from double to single quotes
2014-07-06 21:46:24 -04:00
Adam Krebs
7afdc65e04 Merge pull request #3215 from austentalbot/patch-2
Add missing semicolon
2014-07-06 21:45:25 -04:00
Austen Talbot
05cab3a4fb Add missing semicolon 2014-07-06 15:33:22 -07:00
Austen Talbot
4807136e34 Switch from double to single quotes
Switch from double to single quotes for consistency with rest of file
2014-07-06 15:27:37 -07:00
Jeremy Ashkenas
8761f25c7d Merge pull request #3133 from caseywebdev/generate-id
Allow Collections to determine uniqueness, not Models
2014-06-27 16:39:20 -04:00
brad dunbar
80edf191ed Merge pull request #3204 from julen/patch-1
Changelog: fixed typo
2014-06-25 10:08:43 -04:00
Julen Ruiz Aizpuru
c1bf4003de Changelog: fixed typo 2014-06-25 16:07:24 +02:00
Casey Foster
4e2d20918f Allow Collections to determine uniqueness, not Models 2014-06-21 08:00:13 -05:00
Adam Krebs
18f9ad669a Merge pull request #3111 from akre54/bower-ignores
Ignore other unecessary bower files
2014-06-17 18:34:45 -04:00
Adam Krebs
872607ded4 Ignore other unecessary bower files 2014-06-17 18:34:18 -04:00
Jeremy Ashkenas
e43dc28a70 Merge pull request #3194 from braddunbar/params-docs
Include query string parsing in the changelog.
2014-06-16 18:16:16 -04:00
Brad Dunbar
33fba0ac25 Include query string parsing in the changelog. 2014-06-16 18:12:53 -04:00
Adam Krebs
11f0fd2fd6 Merge pull request #3190 from rjz/master
Update README URLs
2014-06-11 10:03:20 -04:00