Commit Graph

1674 Commits

Author SHA1 Message Date
Jeremy Ashkenas
b6566ef2d9 Merge pull request #1954 from derickbailey/listenTo_stopListening_context
add context as 4th parameter to listenTo and stopListening methods on Backbone.Events
2012-12-17 14:01:10 -08:00
Jeremy Ashkenas
6f0e4cc8ae Merge pull request #1955 from johtso/get-by-idattr
Improve getting of models with non-default ids
2012-12-17 13:42:57 -08:00
Jeremy Ashkenas
132f123212 Merge pull request #1957 from tgriesser/validateDocs
Fixing docs on validate
2012-12-17 11:27:52 -08:00
Tim Griesser
0745d23fd0 fixing docs on validate 2012-12-17 14:25:45 -05:00
Johannes
17fba9e8bd Fix getting model from collection by model
Previously wouldn't work if using non-default id. Thanks to @caseywebdev for pointing this out.
2012-12-17 19:21:34 +00:00
Jeremy Ashkenas
1cc5ede86d Merge pull request #1956 from wyuenho/master
Fix #1925, Document for {sort:false}
2012-12-17 11:21:14 -08:00
Jimmy Yuen Ho Wong
75a52dbc32 Fix #1925 document for {sort:false} 2012-12-18 03:08:53 +08:00
Johannes
9ae12715e2 Make use of new .get() functionality in .update() 2012-12-17 17:48:56 +00:00
Johannes
65ec60ed12 Improve getting of models with non-default ids
Just as you can get a model from a collection using default ids by passing .get() an object i.e. col.get({id: 1}), you can now do the same when using non-default ids i.e. col.get({_id: 1}) (If the collection prototype has the correct model set).
2012-12-17 17:05:14 +00:00
Jeremy Ashkenas
c13005a84a Merge pull request #1947 from cdavaz/master
default constructor should return parent value
2012-12-17 08:27:39 -08:00
Jeremy Ashkenas
25505d6700 Merge pull request #1951 from caseywebdev/parse
Fix #1939 - `parse` receives `options`
2012-12-17 08:03:15 -08:00
Derick Bailey
64aa208b5a fixed typo on context var in stopListening 2012-12-17 09:01:32 -06:00
Derick Bailey
90099afc31 accounting for event maps 2012-12-17 09:00:42 -06:00
Derick Bailey
d6dd3d8647 updated docs to add context param in listenTo and stopListening 2012-12-17 08:17:03 -06:00
Derick Bailey
015e60dbb7 allow context as 4th parameter of stopListening 2012-12-17 08:15:28 -06:00
Derick Bailey
74c674d682 allow context as 4th parameter to Events#listenTo method 2012-12-17 08:08:27 -06:00
Casey Foster
5f7240844c Fix #1939 - parse receives options 2012-12-16 13:03:05 -08:00
Chris Davaz
3666613020 default constructor should return parent value
I came across this issue with a class that caches instances when
they are firste created. Subsequent calls to the constructor will
return the cached instance if available. This relies on a feature
of JavaScript described here:

http://bclary.com/2004/11/07/#a-13.2.2

Note Step 7 in the reference document. By not returning the value
from the default constructor, subclasses of Backbone classes that
rely on this feature will break.
2012-12-14 16:07:27 -08:00
Jeremy Ashkenas
523fb81779 Merge pull request #1940 from gsamokovarov/document-id-classname
Document View#id and View#className as functions
2012-12-14 13:38:24 -08:00
Jeremy Ashkenas
ff5876add2 Merge pull request #1941 from gsamokovarov/update-bullet-typo
Fix typo in update changelog bullet
2012-12-14 13:37:54 -08:00
Jeremy Ashkenas
c1a9384e9c Merge pull request #1944 from tgriesser/isEqualChange
Fix #1943 - use _.isEqual to check model change
2012-12-14 13:23:57 -08:00
Jeremy Ashkenas
8a4af7212e tweaking catalog of events 2012-12-14 16:01:23 -05:00
Jeremy Ashkenas
31655fc6b2 Merge pull request #1945 from akre54/docs-route-event
Document `route` event of Backbone.history
2012-12-14 12:58:36 -08:00
Adam Krebs
919bd91484 catalog the route event on history when Router.route matches 2012-12-14 15:49:18 -05:00
Tim Griesser
bb67b6c60d using isEqual to check model change 2012-12-14 15:09:41 -05:00
Genadi Samokovarov
c1b0224253 Fix typo in update changelog bullet 2012-12-14 20:49:50 +02:00
Genadi Samokovarov
6aaec10a3d Document View#id and View#className as functions 2012-12-14 20:17:56 +02:00
Jeremy Ashkenas
8d243b5e78 tweak setDomLibrary changelog 2012-12-14 11:14:31 -05:00
Jeremy Ashkenas
bc8b829225 Merge pull request #1926 from nervetattoo/patch-1
Add changelog note about deprecated setDomLibrary
2012-12-14 08:12:22 -08:00
Jeremy Ashkenas
abd938f3cd Fixes #1929 -- clarify the change to 'parse' behavior 2012-12-14 11:08:08 -05:00
Jeremy Ashkenas
884e4eee55 Fixes #1931 -- document Backbone mixing in Events 2012-12-14 11:02:09 -05:00
Jeremy Ashkenas
91eb6c3242 re-docc'ing todo example with listenTo. 2012-12-14 10:52:17 -05:00
Jeremy Ashkenas
ef0225e16a Merge pull request #1933 from yuku-t/update-todos
using 'listenTo' instead of 'on' in todos example app
2012-12-14 07:50:54 -08:00
Jeremy Ashkenas
399afd827b Fixes #1937 -- fixes source annotations 2012-12-14 10:32:45 -05:00
Jeremy Ashkenas
68b650d71d Merge branch 'gh-pages' of github.com:documentcloud/backbone into gh-pages 2012-12-14 10:28:35 -05:00
Jeremy Ashkenas
4e239d48c4 Fixes #1928 -- document the new 'request' event. 2012-12-14 10:28:13 -05:00
Jeremy Ashkenas
1da76a2dd7 Merge pull request #1936 from tgriesser/validation-line
Removing line about silent:true delaying validation
2012-12-14 07:18:25 -08:00
Tim Griesser
5d3edae026 removing line about silent delaying validation 2012-12-14 10:13:44 -05:00
Jeremy Ashkenas
ab8364e40f Fixes #1924 -- properly document fetch-with-update 2012-12-14 10:13:14 -05:00
Yuku Takahashi
bb0d351950 using 'listenTo' instead of 'on' in todos example app 2012-12-14 22:40:27 +09:00
Raymond Julin
cd9a90af08 Add changelog note about deprecated setDomLibrary 2012-12-14 08:59:28 +01:00
Jeremy Ashkenas
0085732068 typo 2012-12-13 22:57:23 -05:00
Jeremy Ashkenas
3efc1eda4f Fix #1922 -- document removal of getByCid 2012-12-13 20:30:22 -05:00
Jeremy Ashkenas
3f345dd261 Merge pull request #1921 from mindscratch/master
type in index.html
2012-12-13 16:38:40 -08:00
mindscratch
501c2e74cf fixed typo
changed "fiew" to "few"
2012-12-13 19:01:52 -05:00
Jeremy Ashkenas
3ccde89a97 router test tweak to placate oldIEs 2012-12-13 18:37:35 -05:00
Jeremy Ashkenas
328e721896 router test tweak to placate oldIEs 2012-12-13 18:36:43 -05:00
Jeremy Ashkenas
aaaefd21d8 tweaking test case for IE7 2012-12-13 18:31:31 -05:00
Jeremy Ashkenas
9b97cc3442 adding a 'listenTo' example to the main View docco. 2012-12-13 18:16:01 -05:00
Jeremy Ashkenas
5342d3d5d8 removing old isValid tests 2012-12-13 18:05:06 -05:00