Brad Dunbar
f329cbffe4
only increment length once
2012-01-11 17:37:51 -05:00
Jeremy Ashkenas
8cfb243b8e
Fixes #836 , Fixes #708 -- going back to previous stance: two models with the same id can't be added to the same collection.
2012-01-11 17:03:30 -05:00
Jeremy Ashkenas
cb7090db77
fixes #838 -- allow View#attributes to be defined as a function, as well as a value.
2012-01-11 16:47:50 -05:00
Jeremy Ashkenas
d3ae0aa92a
Fixes #839
2012-01-11 15:56:27 -05:00
Jeremy Ashkenas
3cbd7909f1
clarifying paragraph for #843
2012-01-11 15:46:45 -05:00
Jeremy Ashkenas
bf1ffbeb67
nice refactor. removed _add and _remove and moved 'em in to the public API.
2012-01-11 13:45:16 -05:00
Jeremy Ashkenas
eb868b66c8
merging in #846
2012-01-11 12:28:38 -05:00
Jeremy Ashkenas
2312b9072c
adding a test to ensure that routes aren't triggered multiple times. #849
2012-01-11 12:11:10 -05:00
Jeremy Ashkenas
933469a2bd
Merge pull request #851 from mickeyreiss/master
...
Switch order of delegateEvents and initialize in View constructor
2012-01-11 09:04:49 -08:00
Jeremy Ashkenas
1675e76cb7
Merge branch 'master' of github.com:documentcloud/backbone
2012-01-11 11:56:22 -05:00
Jeremy Ashkenas
df716504cb
Documentation request in #599
2012-01-11 11:56:01 -05:00
Brad Dunbar
c8919c4b05
collection.add should not alter models array
2012-01-10 17:18:11 -05:00
Jeremy Ashkenas
68d95c82ac
Merge pull request #852 from braddunbar/no-bindall
...
No need to _.bindAll _onModelEvent
2012-01-10 07:18:05 -08:00
Brad Dunbar
61b277937e
no need to _.bindAll _onModelEvent
2012-01-10 07:16:53 -05:00
Mickey Reiss
478aaf3d00
Switched order of delegateEvents and initialize in Backbone.View constructor in order to allow for explicit setting of this.el in initialize (and ensure that events are bound correctly).
2012-01-09 13:49:32 -05:00
Jeremy Ashkenas
780ddd393c
Adding Diaspora as an example app.
2012-01-08 09:55:21 -05:00
Brad Dunbar
1ffae591c8
only call splice once instead of on each add
2012-01-06 19:37:38 -05:00
Jeremy Ashkenas
1715c181ad
Fixes #81 -- optimize for addition of large arrays of models, not for individual inserts.
2012-01-06 15:42:43 -05:00
Jeremy Ashkenas
6b3ff7b035
Fixes #9 , Backbone comparators can now be either sort() or sortBy() iterators.
2012-01-06 14:53:43 -05:00
Jeremy Ashkenas
44bb57a217
being a bit stricter about comment wrapping at 80 chars.
2012-01-06 14:13:49 -05:00
Jeremy Ashkenas
060da2b991
Merge pull request #842 from braddunbar/hasChanged-comparison
...
hasChanged/set should use the same comparison
2012-01-06 06:58:55 -08:00
Brad Dunbar
934aba4c6e
hasChanged/set should use the same comparison
...
When setting a value, if hasChanged and set disagree
about equality then hasChanged will return true without
firing a 'changed:*' event (or vice versa). Using the
same comparison (_.isEqual) solves this problem.
2012-01-06 09:19:23 -05:00
Jeremy Ashkenas
d06e8a6854
Adding Picplum as an example app
2011-12-30 09:00:02 -05:00
Jeremy Ashkenas
9a56d525b7
streamlining idAttribute documentation.
2011-12-30 08:51:50 -05:00
Tim Branyen
7420342d5c
Merge pull request #821 from iros/819.idAttribute
...
Added idAttribute navigation link to sidebar
2011-12-26 12:15:54 -08:00
Irene Ros
1591c4290d
Added navigation link
2011-12-26 15:07:02 -05:00
Tim Branyen
a04c248120
Merge pull request #820 from iros/819.idAttribute
...
documenting idAttribute
2011-12-26 12:05:17 -08:00
Irene Ros
570156914d
#819 documenting idAttribute. Also requested on pull req #210 .
2011-12-26 15:00:02 -05:00
Jeremy Ashkenas
4226d58797
Merge branch 'master' of github.com:documentcloud/backbone
2011-12-26 09:35:32 -08:00
Jeremy Ashkenas
ee305c469e
Fixes #818
2011-12-26 09:35:11 -08:00
Jeremy Ashkenas
061fd3ba4f
Merge pull request #809 from islandr/master
...
Allow Model.urlRoot to be a function
2011-12-25 22:46:12 -08:00
=
93a39110de
Use getValue to interpret urlRoot instead.
2011-12-22 17:19:07 -10:00
=
9374fe5a30
Merge branch 'urlrootasfunction'
2011-12-22 15:27:45 -10:00
=
b4e650b98f
A model's urlRoot can now be a function allowing definition at runtime.
2011-12-22 15:23:12 -10:00
Tim Branyen
a9fcd9b3ce
Merge pull request #807 from iros/qunit.force.order
...
Force quint test execution order.
2011-12-22 09:26:17 -08:00
Irene Ros
9d145abfe8
Forcing quint test execution order.
2011-12-22 12:23:50 -05:00
Jeremy Ashkenas
04cb79a528
Merge pull request #805 from fabiomcosta/patch-1
...
\w still includes \d
2011-12-20 19:33:42 -08:00
Fábio M. Costa
9e80ca1457
\w still includes \d http://www.regular-expressions.info/charclass.html#shorthand
2011-12-21 01:29:50 -02:00
Jeremy Ashkenas
d644a4bc0f
Merge pull request #804 from davidmurdoch/patch-1
...
Optimize regular expressions.
2011-12-20 15:51:27 -08:00
David Murdoch
6ccdbb3a60
Optimize regular expressions. The capture groups aren't needed/used; the character classes will do the job just fine.
...
Also, normalize the use of quotation-marks (change `"` to `'`' where appropriate).
2011-12-20 18:18:08 -05:00
Jeremy Ashkenas
cda555acc5
Adding Posterous Spaces as an example app
2011-12-20 13:46:53 -05:00
Jeremy Ashkenas
dd83f2057c
Fixes #788
2011-12-19 11:20:37 -05:00
Jeremy Ashkenas
c3852b8cd1
unifying property-or-function logic.
2011-12-19 10:54:50 -05:00
Jeremy Ashkenas
d806f7e1f3
fixing commit note bug.
2011-12-16 09:59:06 -05:00
Jeremy Ashkenas
a50b71434b
Fixes #792
2011-12-16 09:43:43 -05:00
Jeremy Ashkenas
1400eea12a
Fixes #732
2011-12-06 16:39:37 -05:00
Jeremy Ashkenas
1626fa7447
Fixes #734
2011-12-06 16:21:20 -05:00
Jeremy Ashkenas
64d8fd6ca2
merging in ducksboard.
2011-12-06 15:29:45 -05:00
Aitor Guevara Escalante
14dd201574
Add Ducksboard as an example app.
2011-12-05 20:34:15 +01:00
Jeremy Ashkenas
e10525d4d4
Merge pull request #772 from rgieseke/master
...
Fixes issue 498.
2011-12-05 08:48:49 -08:00