Jeremy Ashkenas
|
18b445e8a0
|
Backbone 0.9.9
0.9.9
|
2012-12-13 17:44:31 -05:00 |
|
Jeremy Ashkenas
|
87a25d5b70
|
Merge pull request #1920 from caseywebdev/master
Fix #1915 - `parse` ordering in `update`
|
2012-12-13 12:58:29 -08:00 |
|
Casey Foster
|
74ae40ea72
|
Fix #1915 - parse ordering in update
|
2012-12-13 12:56:11 -08:00 |
|
Jeremy Ashkenas
|
50c41d3e88
|
Merge pull request #1916 from caseywebdev/events
Cache context, avoid switch in loop, profit
|
2012-12-13 12:15:08 -08:00 |
|
Jeremy Ashkenas
|
abd96d6d7a
|
inlining defaults
|
2012-12-13 15:00:58 -05:00 |
|
Jeremy Ashkenas
|
bd31613cd7
|
Fix earlier commit -- got my defaults ordering backwards.
|
2012-12-13 15:00:17 -05:00 |
|
Jeremy Ashkenas
|
d2e2e93008
|
Merge pull request #1917 from elasticsales/master
failing unit tests with 'defaults'
|
2012-12-13 11:58:42 -08:00 |
|
Phil Freo
|
dc0bfe40d8
|
failing unit tests with 'defaults'
|
2012-12-13 14:54:44 -05:00 |
|
Casey Foster
|
1806a8d368
|
Cache context, avoid switch in loop, profit
|
2012-12-13 11:50:39 -08:00 |
|
Jeremy Ashkenas
|
daf6892d22
|
Fixes #1912 -- Collection#fetch only parses once.
|
2012-12-13 13:54:59 -05:00 |
|
Jeremy Ashkenas
|
50be4423f1
|
Fixes #1913 -- updates Backbone defaults semantics to use _.defaults.
|
2012-12-13 13:23:13 -05:00 |
|
Jeremy Ashkenas
|
27d9428472
|
Merge pull request #1911 from gsamokovarov/bump-to-underscore-14
Bump Underscore to 1.4.3 in package.json and index.html
|
2012-12-13 06:01:56 -08:00 |
|
Genadi Samokovarov
|
0737deecd7
|
Bump Underscore to 1.4.3 in package.json and index.html
|
2012-12-13 15:35:39 +02:00 |
|
Jeremy Ashkenas
|
9365dacc30
|
Revert "removing false optimization, inlining triggerEvents. Thanks @caseywebdev"
This reverts commit 957595f56f.
|
2012-12-13 00:52:32 -05:00 |
|
Jeremy Ashkenas
|
957595f56f
|
removing false optimization, inlining triggerEvents. Thanks @caseywebdev
|
2012-12-12 20:34:10 -05:00 |
|
Jeremy Ashkenas
|
df74b030e9
|
Merge pull request #1907 from tgriesser/patch-bug
Fixing issue in patch not sending data
|
2012-12-12 17:27:24 -08:00 |
|
Tim Griesser
|
cc164563d6
|
fixing issue in patch not sending data
|
2012-12-12 19:42:21 -05:00 |
|
Jeremy Ashkenas
|
b7102e0a61
|
Merge pull request #1905 from caseywebdev/update
Simplify/robustify `update`
|
2012-12-12 14:29:13 -08:00 |
|
Jeremy Ashkenas
|
bd095293e9
|
rename _currentState to _currentAttributes
|
2012-12-12 17:19:35 -05:00 |
|
Jeremy Ashkenas
|
66e25ef5ca
|
Removing pedantic definition of internal private variables
|
2012-12-12 17:11:58 -05:00 |
|
Jeremy Ashkenas
|
f8753b8fea
|
various simplifications to _computeChanges
|
2012-12-12 17:03:12 -05:00 |
|
Jeremy Ashkenas
|
69b3c1382d
|
optimize computeChanges() by removing a splice, and fix a bug with multiple falsy values being set for an attribute
|
2012-12-12 16:48:33 -05:00 |
|
Jeremy Ashkenas
|
6ea96c167d
|
unset does *not* need to fire a change for undefined attributes
|
2012-12-12 16:29:29 -05:00 |
|
Jeremy Ashkenas
|
02a78ac9ae
|
adding a test to ensure that changes are triggered in the appropriate order.
|
2012-12-12 16:24:22 -05:00 |
|
Jeremy Ashkenas
|
a5299f8058
|
removing escape handling of undefined in favor of an upgraded Underscore.js
|
2012-12-12 16:19:07 -05:00 |
|
Jeremy Ashkenas
|
bcce5f4f6c
|
renaming 'set' internals, for clarity
|
2012-12-12 16:17:23 -05:00 |
|
Jeremy Ashkenas
|
ba7a279f7c
|
moving unset loop from set into unset itself
|
2012-12-12 16:05:44 -05:00 |
|
Jeremy Ashkenas
|
36c3e44e19
|
you shouldn't be able to set(model), instead set(model.attributes)
|
2012-12-12 16:02:40 -05:00 |
|
Jeremy Ashkenas
|
b978df1ac3
|
removing escapedAttributes caching for simplicity's sake
|
2012-12-12 15:58:22 -05:00 |
|
Jeremy Ashkenas
|
6459a39949
|
expanding comments
|
2012-12-12 14:09:55 -05:00 |
|
Jeremy Ashkenas
|
72a24ecf40
|
renaming 'cb' to 'callback' for clarity, and refactoring Events#off
|
2012-12-12 13:56:00 -05:00 |
|
Jeremy Ashkenas
|
4439b214e7
|
add one more switch case to triggerEvents, because most built-in backbone events are called with 3 arguments.
|
2012-12-12 13:29:26 -05:00 |
|
Casey Foster
|
1bd34b061a
|
Simplify/robustify update
|
2012-12-12 10:27:17 -08:00 |
|
Jeremy Ashkenas
|
644aecc487
|
(hopefully) simplifying and optimizing 'trigger' further
|
2012-12-12 13:25:08 -05:00 |
|
Jeremy Ashkenas
|
ac94b84c56
|
working version, WIP
|
2012-12-12 13:05:48 -05:00 |
|
Jeremy Ashkenas
|
b2b014228c
|
merged in casey's events optimizations ... tweaking to follow
|
2012-12-12 12:00:55 -05:00 |
|
Casey Foster
|
15bf791dc3
|
Implement brad's off with _.once
|
2012-12-12 08:43:02 -08:00 |
|
Jeremy Ashkenas
|
9de1ddd1c1
|
back to previous 'once' implementation ... tbd
|
2012-12-12 11:33:26 -05:00 |
|
Jeremy Ashkenas
|
aa4c056ef6
|
renaming once'd event callback for clarity -- new failing test.
|
2012-12-12 11:15:17 -05:00 |
|
Jeremy Ashkenas
|
9ce995df70
|
spacing for off condition
|
2012-12-12 11:09:23 -05:00 |
|
Jeremy Ashkenas
|
89936d8f39
|
simplifying trigger condition
|
2012-12-12 11:08:36 -05:00 |
|
Jeremy Ashkenas
|
4d9776e50e
|
DRY-ing up event map support
|
2012-12-12 10:52:15 -05:00 |
|
Jeremy Ashkenas
|
f0da2ebec5
|
Merge pull request #1890 from braddunbar/once
Implement once with minimal change to other Events methods.
|
2012-12-12 07:43:26 -08:00 |
|
Casey Foster
|
307b293ab9
|
Final events optimizations and rebase
|
2012-12-11 15:08:26 -08:00 |
|
Casey Foster
|
2a7a45a6a5
|
Account for once("all", ...)
|
2012-12-11 14:53:26 -08:00 |
|
Casey Foster
|
842f48f224
|
Events revamp alternative version
|
2012-12-11 14:51:20 -08:00 |
|
Casey Foster
|
9e07557c24
|
Revamped events
- Fix awkward event order in test
- Remove all slice/splice calls (too slow)
- Break out of loops/functions ASAP
|
2012-12-11 14:51:20 -08:00 |
|
Jeremy Ashkenas
|
7e7b214269
|
revised update implementation with inline id/cid map instead of using an inline Collection for speed. Plus tests.
|
2012-12-11 17:10:02 -05:00 |
|
Jeremy Ashkenas
|
601feb3def
|
don't blow up if you try to stopListening() an object, but have never listened in the first place
|
2012-12-11 14:41:31 -05:00 |
|
Jeremy Ashkenas
|
0494252446
|
Make event maps a bit more lenient about context, for internal convenience.
|
2012-12-11 14:02:37 -05:00 |
|