3286 Commits

Author SHA1 Message Date
Justin Ridgewell
7fe056cd24 Bump to v1.3.1
Because I screwed up the 1.3.0 release by not building the min files...
Sorry everyone.
1.3.1
2016-03-03 22:06:21 -05:00
Justin Ridgewell
2dd94cc2f8 Build v1.3 1.3.0 2016-03-03 22:01:23 -05:00
Justin Ridgewell
478e708ade 1.3.0 v1.3.0 2016-03-03 21:54:25 -05:00
Justin Ridgewell
dcac2b586d Merge pull request #3921 from jdalton/changelog
Draft changelog for Backbone 1.3.0
2016-03-03 21:53:15 -05:00
Adam Krebs
712b42b4f3 code golf modelId example a bit more 2016-03-02 13:14:52 -05:00
John-David Dalton
8b976a4ae2 Update changelog for 1.3.0. 2016-02-08 13:41:23 -08:00
Ash Lux
32d89dc47e When listening to numerous events and stopListening is called, then _.isEmpty is painfully slowly and assigning _listenTo to undefined isn't necessary. 2016-02-08 15:16:10 -05:00
Graeme Yeates
5bc98095f7 Merge pull request #3927 from jashkenas/megawac-patch-1
Silent true note for collection.remove
2016-02-08 15:09:39 -05:00
Graeme Yeates
e5353fb484 Merge pull request #3947 from sam-at-github/master
Minor update to docs.
2016-02-08 15:06:47 -05:00
Justin Ridgewell
82bdb8939b Merge pull request #3956 from jshen212/patch-1
Line 1920 - Fix Spacing After Return
2016-02-05 14:34:31 -05:00
Jeff Shen
28588e1b96 Line 1920 - Fix Spacing After Return
Fixed spacing after return to match the rest of the code
2016-02-05 11:11:57 -08:00
Adam Krebs
8d8b854abf rename at => val in test to be clearer 2016-02-04 17:16:06 -05:00
Justin Ridgewell
5a6a82450a Merge pull request #3936 from craigmichaelmartin/optimize-collection-get
optimize collection get
2016-02-04 16:00:04 -05:00
Craig Martin
8932ae4bc3 optimize collection get and account for edge case 2016-02-04 15:30:26 -05:00
Justin Ridgewell
8e37d6758c Merge pull request #3952 from craigmichaelmartin/fix-linting-errors
fix failing linting tests
2016-02-04 15:23:15 -05:00
Craig Martin
47fb04a373 fix failing linting tests 2016-02-04 15:16:41 -05:00
Adam Krebs
b0161947eb Fix #3951: options.index should never exceed collection.length 2016-02-04 15:01:59 -05:00
Adam Krebs
08a486cb8a Merge pull request #3843 from jridgewell/defaults-prototype-collision
Avoid Object.prototype collisions with defaults
2016-02-04 12:23:43 -05:00
Justin Ridgewell
92fb299c2a Use _.extend to avoid Object.prototype collisions 2016-02-03 12:56:45 -05:00
Justin Ridgewell
159ce4afad Merge pull request #3949 from pra85/patch-1
Fixes typo in docs
2016-02-02 23:39:28 -05:00
Prayag Verma
ad1a6b85ad Fixes typo in docs
Found a spelling mistake -
`deprectated` > `deprecated`
2016-02-03 10:05:44 +05:30
Justin Ridgewell
67790b27de Merge pull request #3945 from jridgewell/collection-has-test-fix
Use strictEqual in Collection#has Tests
2016-02-02 11:27:19 -05:00
Justin Ridgewell
2f85060e59 Upgrade vendor QUnit 2016-02-02 11:21:37 -05:00
Graeme Yeates
c380607704 Merge pull request #3940 from roycetucker/patch-2
Fixing object notation for Events.once
2016-02-01 13:52:57 -05:00
Adam Krebs
344a4292f5 Merge pull request #3948 from megawac/col-update
Pass updated models in the Collection "update" event
2016-02-01 09:40:02 -07:00
Graeme Yeates
670ff30aa4 Improve collection 'update' event consistency 2016-02-01 11:33:39 -05:00
Linus-A. M. Gubenis
90cb566250 Pass added and removed models to collection update events 2016-02-01 11:18:09 -05:00
sam-at-github
f55b154ad3 Minor update to docs. Qualify the behaviour of fetch({reset: true}). Link doc on reset event to reset method. 2016-02-01 15:45:37 +11:00
Royce Tucker
d2099dd283 Adding a unit test for once with object notation 2016-01-30 14:37:37 -06:00
Royce Tucker
00f5c39e27 Fixing object notation for Events.once 2016-01-28 13:05:35 -06:00
Adam Krebs
45f4ebaac1 Merge pull request #3938 from craigmichaelmartin/patch-1
disable npm's progress bar in travis ci for quicker install
2016-01-27 09:27:17 -05:00
Craig Martin
80ccab0ac8 disable npm's progress bar in travis ci for quicker install
See https://github.com/npm/npm/issues/11283
2016-01-27 09:23:50 -05:00
Justin Ridgewell
be1c967a26 Merge pull request #3934 from craigmichaelmartin/fix-modelId-example
fix modelId example
2016-01-25 10:22:51 -08:00
Craig Martin
4caa6e6835 fix modelId example 2016-01-23 22:52:27 -05:00
Adam Krebs
ecdb7ad886 Merge pull request #3933 from craigmichaelmartin/add-id-test-for-polymorphic
add tests solidifying behavior for modelId with polymorphic models
2016-01-20 11:02:48 -05:00
Craig Martin
1aa7f7685a add tests solidifying behavior for modelId with polymorphic models 2016-01-20 09:23:50 -05:00
Adam Krebs
82d8ec840c Merge pull request #3929 from craigmichaelmartin/avoid-redefinitions
eliminate shadowed variable declarations
2016-01-19 13:56:36 -05:00
Craig Martin
e0a5cc75ba eliminate shadowed variable declarations
Also, add eslint rule no-shadow to enforce
2016-01-19 12:34:08 -05:00
Adam Krebs
6d37e06003 Merge pull request #3928 from captbaritone/year
Update copyright year
2016-01-19 09:49:50 -05:00
Adam Krebs
2f9d048df8 Merge pull request #3930 from craigmichaelmartin/add-collection-has
add `has` method to collection
2016-01-19 09:47:14 -05:00
Craig Martin
75666b08c9 add has method to collection 2016-01-17 12:19:36 -05:00
Jordan Eldredge
dfe0e17d09 Update copyright year 2016-01-16 20:32:52 -08:00
Justin Ridgewell
bc56c5a2df Merge pull request #3907 from captbaritone/eslint-8
Add ESLint rule: no-unused-expressions
2016-01-15 22:51:11 -05:00
Justin Ridgewell
2a78313c63 Merge pull request #3886 from ClimbsRocks/patch-1
Update wording to "space-separated" to be consistent
2016-01-15 22:00:21 -05:00
Graeme Yeates
a8b7117a22 Fix formatting 2016-01-14 13:15:23 -05:00
Graeme Yeates
7eeecf43e3 Silent true note for collection.remove 2016-01-14 12:51:11 -05:00
Adam Krebs
c20ca2e3f6 Merge pull request #3911 from captbaritone/nested-ternary
Avoid nested ternary
2016-01-05 11:27:02 -05:00
Justin Ridgewell
19e2d29cef Merge pull request #3917 from paulfalgout/remove-component
Remove deprecated component.json
2016-01-04 12:02:10 -05:00
Paul Falgout
be14f69342 Remove deprecated component.json
component.json has been [deprecated since June](https://github.com/componentjs/component#this-project-is-deprecated)

So there's no reason to keep maintaining it.

And as it is, @jashkenas [does](https://github.com/jashkenas/underscore/pull/884#issuecomment-10999128) [not](https://github.com/jashkenas/backbone/pull/2622#issuecomment-19669694) [like](https://github.com/jashkenas/backbone/pull/2811#issuecomment-26351438) [it](28d345a231 (commitcomment-4557129)).
2016-01-03 22:44:33 -06:00
Jordan Eldredge
ff555e7664 Avoid nested ternary
While looking into adding the "no-nested-ternary" ESLint rule, I realized that
this logic could be refactored a bit.

This nested ternary was introduced in pull request #3875 in order to handle
falsy returns from `parse()`.

This refactor avoids the nested ternary and also makes the intent clearer by
associating the empty array directly with `parse()`'s return.

It also more narrowly handles the falsy case (we never intended to allow you
call `set(0)` for example.)

The only down side I can see is that if `parse()` returns falsy, we will
unnecessarily slice/clone the empty array we just created.
2015-12-29 09:15:07 -08:00