Commit Graph

  • b44ee9900e broken link for tilemill example shidel.dev 2014-03-14 16:31:00 -05:00
  • 7180d5ce0a Add #_setAttributes and clean up #setElement. Brad Dunbar 2014-03-14 12:27:16 -04:00
  • 155a738ad8 Merge pull request #19 from braddunbar/view-hooks Adam Krebs 2014-03-14 16:02:51 +00:00
  • 72f7da4208 A little clarification. Brad Dunbar 2014-03-14 07:10:40 -04:00
  • b79bd78abc Merge pull request #18 from wyuenho/view-native-hooks Adam Krebs 2014-03-14 15:22:28 +00:00
  • ad39972d5d Return undefined from delegate Jimmy Yuen Ho Wong 2014-03-14 18:04:18 +08:00
  • ba88916067 Merge pull request #3063 from janaspage/correct-split-infinitives Jeremy Ashkenas 2014-03-14 00:01:15 -04:00
  • 4e8caf4471 no need for repeated comment on remove Adam Krebs 2014-03-14 06:38:18 +04:00
  • 3f79ea88bf fix leftover merge conflict Adam Krebs 2014-03-14 06:36:20 +04:00
  • f67c7a11c3 test delegate returns listener Adam Krebs 2014-03-14 06:35:20 +04:00
  • 06586f3283 shorter comment Adam Krebs 2014-03-14 06:23:24 +04:00
  • c5c0d2ef0c Merge branch 'master' into view-native-hooks Adam Krebs 2014-03-14 06:20:59 +04:00
  • 3580496c91 Correct split infinitives. Janas Page 2014-03-13 18:18:19 -07:00
  • b5f1574b27 Merge pull request #3060 from braddunbar/delegate-events Jeremy Ashkenas 2014-03-13 18:38:01 -04:00
  • 264bd9b3da comments cleanup Adam Krebs 2014-03-13 20:33:48 +04:00
  • 764eef407b shorter undelegate Adam Krebs 2014-03-13 15:27:35 +04:00
  • 291f3bcde4 nicer jq test Adam Krebs 2014-03-13 12:59:36 +04:00
  • b59b621b29 shorter delegate method thanks to jQuery empty selector checks Adam Krebs 2014-03-13 12:20:13 +04:00
  • ab802ba4a0 Always delegate in #setElement. Brad Dunbar 2014-03-13 01:00:33 -04:00
  • 3850d37def add missing semi Adam Krebs 2014-03-12 19:55:08 +04:00
  • d99e43b564 test for undelegate with handler and selector, and use an element that exists in the DOM for bubbling Adam Krebs 2014-03-12 15:20:40 +04:00
  • d21fd79d8f remove namespace test from custom events test. Adam Krebs 2014-03-12 15:16:33 +04:00
  • be11f3a010 add an undelegate method to View and pass back the listener from delegate Adam Krebs 2014-03-12 10:10:37 +04:00
  • 20ed07489e rename _setEl to _setElement for parity Adam Krebs 2014-03-11 11:29:07 +04:00
  • b377e308ad Merge remote-tracking branch 'wyuenho/view-native-hooks' into view-native-hooks Adam Krebs 2014-03-11 11:27:30 +04:00
  • 6e5d3e9c57 Merge pull request #3054 from caseywebdev/deps Jeremy Ashkenas 2014-03-10 14:58:05 -04:00
  • 7a0f833fad Update devDependencies Casey Foster 2014-03-10 13:51:27 -05:00
  • 393a209ca8 Merge _remove and remove tests and remove _setEl tests Jimmy Yuen Ho Wong 2014-03-09 17:05:20 +08:00
  • b840669fa7 Rename _removeElement to _remove and test _remove for event undelegation Jimmy Yuen Ho Wong 2014-03-09 02:19:11 +08:00
  • 58c9a2abc6 remove undelegateEvents call from remove Adam Krebs 2014-03-09 11:31:40 +04:00
  • c0a5f9d16b Merge pull request #3053 from sfishel18/master Adam Krebs 2014-03-10 05:33:38 +00:00
  • 6b0314e0e4 remove un-used local variables Simon Fishel 2014-03-09 20:41:01 -07:00
  • d9f6c64719 remove undelegateEvents call from remove Adam Krebs 2014-03-09 11:31:40 +04:00
  • cbaa8d144b Pass along textStatus and errorThrown. Brad Dunbar 2014-03-06 17:07:53 -05:00
  • c62708f04b use notEqual body isntead of equal null Adam Krebs 2014-03-06 15:26:44 +04:00
  • bef78ef496 test setEl and el.parentNode Adam Krebs 2014-03-06 15:22:13 +04:00
  • 9eff496762 Revert "View conformance tests" Adam Krebs 2014-03-06 11:14:16 +04:00
  • 6d6999976a test _removeElement Adam Krebs 2014-03-05 09:45:00 +02:00
  • 27111856c1 Merge pull request #16 from wyuenho/view-native-hooks Adam Krebs 2014-03-05 06:39:00 -08:00
  • f814b85db6 Make new tests more thorough Casey Foster 2014-03-05 07:57:39 -06:00
  • 3f7fbdeec6 Return id assumption for simple polymorphic Collection#model factories. Casey Foster 2014-03-05 07:48:27 -06:00
  • 1cb19be4e9 Test for view.remove and view._removeElement Jimmy Yuen Ho Wong 2014-03-05 18:25:25 +08:00
  • 986540f46f swap argument ordering to setElement, boolean goes last Adam Krebs 2014-03-05 09:07:35 +02:00
  • c5aa603b48 rephrase _setEl comment Adam Krebs 2014-03-05 01:13:56 +02:00
  • 7e95b9cc2b short-circuit on attributes Adam Krebs 2014-03-05 01:07:24 +02:00
  • 81809e188f add global Element guard for IE8 Adam Krebs 2014-03-04 23:07:28 +02:00
  • 6cef2f12e5 Check typeof length instead of instanceof Jimmy Yuen Ho Wong 2014-03-04 23:27:08 +08:00
  • fca75fb6bd Fix up global in view test Jimmy Yuen Ho Wong 2014-03-04 23:22:55 +08:00
  • 7339bed6c5 Merge branch 'master' into view-native-hooks Adam Krebs 2014-03-04 23:00:05 +02:00
  • e0233d8062 Merge pull request #3041 from braddunbar/iframe-cleanup Jeremy Ashkenas 2014-03-04 11:40:19 -05:00
  • b362ea0fcc Fix #3015 - History#stop cleans up iframe. Brad Dunbar 2014-03-04 11:35:31 -05:00
  • 5552443175 Merge pull request #3040 from braddunbar/underscore-methods Jeremy Ashkenas 2014-03-04 10:57:33 -05:00
  • 05fbaad186 Update collection docs on underscore methods. Brad Dunbar 2014-03-04 10:55:13 -05:00
  • 0fca38cd82 view test cleanup Adam Krebs 2014-03-04 14:45:22 +02:00
  • 70933e51cf fix merge conflict Adam Krebs 2014-03-04 14:19:35 +02:00
  • a9d066a84e test view.$ interface and rename _createContext to _setEl in view test Adam Krebs 2014-03-04 14:17:42 +02:00
  • 01f794fe99 Merge remote-tracking branch 'wyuenho/view-native-hooks' into view-native-hooks Adam Krebs 2014-03-04 14:15:16 +02:00
  • f13181fbc0 rename _createContext to _setEl Adam Krebs 2014-03-04 13:35:24 +02:00
  • fd6425441d Rename delegate's method param to listener to tell people it's ok to attach an unbound function as handler Jimmy Yuen Ho Wong 2014-03-03 05:07:28 +08:00
  • 446ee523fa save a var in _createContext Adam Krebs 2014-02-27 23:24:20 +02:00
  • e30e6b9344 small cleanup in _createContext Adam Krebs 2014-02-27 18:36:15 +02:00
  • 3edf74c37b return this from delegate Adam Krebs 2014-02-22 09:44:47 -05:00
  • 5dc2d093fb Call _createContext only once during new View Jimmy Yuen Ho Wong 2014-02-22 01:13:53 +08:00
  • 20935c85ee Fix test for fc95eae Jimmy Yuen Ho Wong 2014-02-22 00:02:37 +08:00
  • 72b88b5835 Revert "Speed up method calls in delegateEvents and delegate" Adam Krebs 2014-02-21 10:00:48 -05:00
  • 12abe8eef6 Comment for 2 arg form inside _delegate Jimmy Yuen Ho Wong 2014-02-21 03:31:08 +08:00
  • 25c0beed0f Fix typo Jimmy Yuen Ho Wong 2014-02-21 03:19:38 +08:00
  • 9868bfb862 No reason jQuery can't be a little faster too Jimmy Yuen Ho Wong 2014-02-21 03:13:17 +08:00
  • 390275b82f Fix comment Jimmy Yuen Ho Wong 2014-02-21 02:46:20 +08:00
  • 18d17db554 Disallow chaining in hook calls Jimmy Yuen Ho Wong 2014-02-20 15:22:38 +08:00
  • 6ebb6e1752 _createContext is side-effect only Jimmy Yuen Ho Wong 2014-02-20 14:18:21 +08:00
  • 9028e338c3 Shortened _createContext Jimmy Yuen Ho Wong 2014-02-20 13:05:03 +08:00
  • 1e9cd4a350 Revert introduction of _undelegate Jimmy Yuen Ho Wong 2014-02-20 05:53:13 +08:00
  • d78fb34aff Prefix all hooks with _ and introduce _undelegate Jimmy Yuen Ho Wong 2014-02-20 05:31:36 +08:00
  • 5f66f9af18 Rename make to _createContext and have _ensureElement and setElement delegate to it Jimmy Yuen Ho Wong 2014-02-20 05:11:11 +08:00
  • ad44cb41b6 Further isolate $.remove by exposing removeElement in case subclasses forgot to clean up Jimmy Yuen Ho Wong 2014-02-20 02:11:57 +08:00
  • 3369bf486b Speed up method calls in delegateEvents and delegate Jimmy Yuen Ho Wong 2014-02-20 01:23:30 +08:00
  • be1cba3331 Move delegate up and move check into undelegateEvents Jimmy Yuen Ho Wong 2014-02-20 01:21:39 +08:00
  • 4e5b28221c save two lines in View#make: jquery handles nulls nicely Adam Krebs 2014-02-19 01:07:25 -05:00
  • 90c36cadac add View#delegate as a single event listener version of delegateEvents for easier overriding Adam Krebs 2014-02-18 17:34:54 -05:00
  • 0cdb38b03f revert c1e62cda: add View#make back in for overriding Adam Krebs 2014-02-18 17:09:01 -05:00
  • 7eedd4bc0a View conformance tests Jimmy Yuen Ho Wong 2014-03-03 23:50:04 +08:00
  • 41283909e6 Merge pull request #3037 from rsofaer/update-docs-rails-4 Adam Krebs 2014-03-04 02:20:17 +02:00
  • 7a52396a1b Change the reference to rails in the 'sync' docs to reflect Rails 4 Raphael Sofaer 2014-03-03 11:11:18 -08:00
  • 36e4925b9c #2985 -- use 'change-id' as the event name Jeremy Ashkenas 2014-03-03 13:00:04 -05:00
  • 60b9cc1d18 Merge pull request #2985 from caseywebdev/generate-id Jeremy Ashkenas 2014-03-03 12:56:08 -05:00
  • 0c1838be63 Merge pull request #3032 from akre54/clone-opts Jeremy Ashkenas 2014-03-03 08:23:55 -05:00
  • 16e548397e pass along model and comparator to cloned collection. Fixes #3013 Adam Krebs 2014-03-02 23:10:09 +02:00
  • 6433043649 Rename delegate's method param to listener to tell people it's ok to attach an unbound function as handler Jimmy Yuen Ho Wong 2014-03-03 05:07:28 +08:00
  • bdc5c63944 Merge pull request #3029 from Crisfole/update/underscore brad dunbar 2014-02-28 13:59:42 -05:00
  • 7612699f52 Merge pull request #3030 from caseywebdev/_-guard Jeremy Ashkenas 2014-02-28 13:48:19 -05:00
  • 83c81005fe Re #3029 Guard against unavailable edge underscore proxies Casey Foster 2014-02-28 12:26:26 -06:00
  • fa7e617edf Add new _.partition Christopher Pfohl 2014-02-28 08:50:09 -05:00
  • 6fec7a5772 save a var in _createContext Adam Krebs 2014-02-27 23:24:20 +02:00
  • 1853297cc9 Merge pull request #3006 from akre54/history-native-hooks Jeremy Ashkenas 2014-02-27 13:05:33 -05:00
  • 5bc7333a2a Re #2976 Allow id values to be generated from a function given attrs Casey Foster 2014-02-03 11:49:09 -06:00
  • 933c02e6a1 small cleanup in _createContext Adam Krebs 2014-02-27 18:36:15 +02:00
  • 16b6f1ee23 Merge pull request #10 from wyuenho/history-native-hooks Adam Krebs 2014-02-27 08:55:56 +02:00
  • d4b5f590f8 Merge pull request #3026 from braddunbar/off Jeremy Ashkenas 2014-02-26 18:23:32 -05:00
  • 49123e9ab1 Don't be clever. Brad Dunbar 2014-02-26 17:05:50 -05:00