github/bower
1
1
Fork 0
mirror of https://github.com/bower/bower.git synced 2026-04-24 03:00:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2137 from pwielgolaski/#2129

Browse Source 
when strictSsl is false set GIT_SSL_NO_VERIFY=true for git command
This commit is contained in:
Adam Stankiewicz
2016-01-24 18:14:38 +01:00
parent 9d2681b0c4 f0a54d0018
commit d63047b4ee
2 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/core/resolvers/GitResolver.js
View File

@@ -26,6 +26,7 @@ function GitResolver(decEndpoint, config, logger) {
// anyway
mkdirp.sync(config.storage.empty);
process.env.GIT_TEMPLATE_DIR = config.storage.empty;
process.env.GIT_SSL_NO_VERIFY = (!config.strictSsl).toString();
Resolver.call(this, decEndpoint, config, logger);

20
test/core/resolvers/gitResolver.js
View File

@@ -15,6 +15,7 @@ var defaultConfig = require('../../../lib/config');
describe('GitResolver', function () {
var tempDir = path.resolve(__dirname, '../../tmp/tmp');
var originalrefs = GitResolver.refs;
var originalEnv = process.env;
var logger;
before(function () {
@@ -23,6 +24,7 @@ describe('GitResolver', function () {
afterEach(function () {
logger.removeAllListeners();
process.env = originalEnv;
});
function clearResolverRuntimeCache() {
@@ -41,6 +43,24 @@ describe('GitResolver', function () {
describe('misc', function () {
it.skip('should error out if git is not installed');
it.skip('should setup git template dir to an empty folder');
it('should set process.env.GIT_SSL_NO_VERIFY when strictSSL is false', function () {
var resolver;
var decEndpoint = { source: 'foo'};
expect(process.env).to.not.have.property('GIT_SSL_NO_VERIFY');
resolver = new GitResolver(decEndpoint, defaultConfig(), logger);
expect(process.env).to.have.property('GIT_SSL_NO_VERIFY','false');
delete process.env.GIT_SSL_NO_VERIFY;
resolver = new GitResolver(decEndpoint, defaultConfig({strictSsl: false}), logger);
expect(process.env).to.have.property('GIT_SSL_NO_VERIFY','true');
delete process.env.GIT_SSL_NO_VERIFY;
resolver = new GitResolver(decEndpoint, defaultConfig({strictSsl: true}), logger);
expect(process.env).to.have.property('GIT_SSL_NO_VERIFY','false');
delete process.env.GIT_SSL_NO_VERIFY;
});
});
describe('.hasNew', function () {