github/concrete
1
1
Fork 0
mirror of https://github.com/zama-ai/concrete.git synced 2026-02-09 03:55:04 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: improve error message of circuits which has TLU and more than 16-bits at the same time

Browse Source
This commit is contained in:
Umut
2023-01-02 14:44:58 +01:00
parent 2bd449518c
commit 155e5b2941
2 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
concrete/numpy/mlir/graph_converter.py
View File

@@ -236,18 +236,21 @@ class GraphConverter:
offending_nodes: Dict[Node, List[str]] = {}
max_bit_width = 0
max_bit_width_node = None
first_tlu_node = None
first_signed_node = None
for node in graph.graph.nodes:
for node in nx.lexicographical_topological_sort(graph.graph):
dtype = node.output.dtype
assert_that(isinstance(dtype, Integer))
current_node_bit_width = (
dtype.bit_width - 1 if node.output.is_clear else dtype.bit_width
)
max_bit_width = max(max_bit_width, current_node_bit_width)
if max_bit_width < current_node_bit_width:
max_bit_width = current_node_bit_width
max_bit_width_node = node
if node.converted_to_table_lookup and first_tlu_node is None:
first_tlu_node = node
@@ -257,9 +260,20 @@ class GraphConverter:
if first_tlu_node is not None:
if max_bit_width > MAXIMUM_TLU_BIT_WIDTH:
assert max_bit_width_node is not None
offending_nodes[max_bit_width_node] = [
(
{
Operation.Input: f"this input is {max_bit_width}-bits",
Operation.Constant: f"this constant is {max_bit_width}-bits",
Operation.Generic: f"this operation results in {max_bit_width}-bits",
}[max_bit_width_node.operation]
),
max_bit_width_node.location,
]
offending_nodes[first_tlu_node] = [
f"table lookups are only supported on circuits with "
f"up to {MAXIMUM_TLU_BIT_WIDTH}-bit integers",
f"up to {MAXIMUM_TLU_BIT_WIDTH}-bits",
first_tlu_node.location,
]

3
tests/mlir/test_graph_converter.py
View File

@@ -381,10 +381,11 @@ return %2
Function you are trying to compile cannot be converted to MLIR:
%0 = x # EncryptedScalar<uint18> ∈ [200000, 200000]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this input is 18-bits
%1 = 300 # ClearScalar<uint9> ∈ [300, 300]
%2 = add(%0, %1) # EncryptedScalar<uint18> ∈ [200300, 200300]
%3 = subgraph(%2) # EncryptedScalar<uint4> ∈ [9, 9]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ table lookups are only supported on circuits with up to 16-bit integers
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ table lookups are only supported on circuits with up to 16-bits
return %3
Subgraphs: