github/concrete
1
1
Fork 0
mirror of https://github.com/zama-ai/concrete.git synced 2026-02-09 03:55:04 -05:00
Code Issues Packages Projects Releases Wiki Activity

feat: introduce maximum bit width constant, use it where appropriate, export it in python bindings

Browse Source
This commit is contained in:
Umut
2022-01-24 12:45:59 +03:00
parent 05ebbb1029
commit 8198a79deb
5 changed files with 22 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
compiler/include/concretelang/Support/Constants.h
View File

@@ -9,6 +9,7 @@
namespace mlir {
namespace concretelang {
constexpr unsigned DEFAULT_PATTERN_BENEFIT = 1;
constexpr unsigned MAXIMUM_BIT_WIDTH = 7;
} // namespace concretelang
} // namespace mlir

6
compiler/lib/Bindings/Python/ConcretelangModule.cpp
View File

@@ -8,6 +8,7 @@
#include "concretelang-c/Dialect/FHE.h"
#include "concretelang-c/Dialect/FHELinalg.h"
#include "concretelang/Support/Constants.h"
#include "mlir-c/Bindings/Python/Interop.h"
#include "mlir-c/Registration.h"
#include "mlir/Bindings/Python/PybindAdaptors.h"
@@ -23,6 +24,9 @@ PYBIND11_MODULE(_concretelang, m) {
llvm::sys::PrintStackTraceOnErrorSignal(/*argv=*/"");
LLVMEnablePrettyStackTrace();
m.attr("MAXIMUM_BIT_WIDTH") =
pybind11::int_(mlir::concretelang::MAXIMUM_BIT_WIDTH);
m.def(
"register_dialects",
[](py::object capsule) {
@@ -45,4 +49,4 @@ PYBIND11_MODULE(_concretelang, m) {
py::module api = m.def_submodule("_compiler", "Compiler API");
mlir::concretelang::python::populateCompilerAPISubmodule(api);
}
}

7
compiler/lib/Dialect/FHE/IR/FHEDialect.cpp
View File

@@ -12,6 +12,8 @@
#include "concretelang/Dialect/FHE/IR/FHEOpsDialect.cpp.inc"
#include "concretelang/Support/Constants.h"
using namespace mlir::concretelang::FHE;
void FHEDialect::initialize() {
@@ -51,8 +53,9 @@ void FHEDialect::printType(::mlir::Type type,
mlir::LogicalResult EncryptedIntegerType::verify(
llvm::function_ref<::mlir::InFlightDiagnostic()> emitError, unsigned p) {
if (p == 0 || p > 7) {
emitError() << "FHE.eint support only precision in ]0;7]";
if (p == 0 || p > mlir::concretelang::MAXIMUM_BIT_WIDTH) {
emitError() << "FHE.eint support only precision in ]0;"
<< mlir::concretelang::MAXIMUM_BIT_WIDTH << "]";
return mlir::failure();
}
return mlir::success();

9
compiler/lib/Dialect/TFHE/IR/TFHEDialect.cpp
View File

@@ -12,6 +12,8 @@
#include "concretelang/Dialect/TFHE/IR/TFHEOpsDialect.cpp.inc"
#include "concretelang/Support/Constants.h"
using namespace mlir::concretelang::TFHE;
void TFHEDialect::initialize() {
@@ -47,7 +49,7 @@ void TFHEDialect::printType(::mlir::Type type,
/// Verify that GLWE parameter are consistant
/// - The bits parameter is 64 (we support only this for v0)
/// - The p parameter is ]0;7]
/// - The p parameter is ]0;MAXIMUM_BIT_WIDTH]
::mlir::LogicalResult GLWECipherTextType::verify(
::llvm::function_ref<::mlir::InFlightDiagnostic()> emitError,
signed dimension, signed polynomialSize, signed bits, signed p) {
@@ -55,8 +57,9 @@ void TFHEDialect::printType(::mlir::Type type,
emitError() << "GLWE bits parameter can only be 64";
return ::mlir::failure();
}
if (p == 0 || p > 7) {
emitError() << "GLWE p parameter can only be in ]0;7]";
if (p == 0 || p > (signed)mlir::concretelang::MAXIMUM_BIT_WIDTH) {
emitError() << "GLWE p parameter can only be in ]0;"
<< mlir::concretelang::MAXIMUM_BIT_WIDTH << "]";
return mlir::failure();
}
return ::mlir::success();

6
compiler/tests/python/test_fhe_dialect.py
View File

@@ -1,9 +1,13 @@
import pytest
from mlir.ir import Context, RankedTensorType, Location
from concrete.lang import register_dialects
from concrete.lang import register_dialects, MAXIMUM_BIT_WIDTH
from concrete.lang.dialects import fhe
def test_constants():
assert MAXIMUM_BIT_WIDTH == 7
@pytest.mark.parametrize("width", list(range(1, 8)))
def test_eint(width):
ctx = Context()