github/concrete
1
1
Fork 0
mirror of https://github.com/zama-ai/concrete.git synced 2026-02-08 11:35:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: global_p_error fails on big 16b circuits

Browse Source 
Resolve zama-ai/concrete-numpy-internal#1858
This commit is contained in:
rudy
2023-03-06 09:22:39 +01:00
committed by Quentin Bourgerie
parent 65fc4ecc21
commit 8ebfccd9a7
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
compilers/concrete-compiler/compiler/lib/Support/V0Parameters.cpp
View File

@@ -76,8 +76,19 @@ optimizer::DagSolution getV1ParameterGlobalPError(optimizer::Dag &dag,
auto surrogate_p_local_success =
pow(ref_global_p_success, power_global_to_local);
options.maximum_acceptable_error_probability =
1.0 - surrogate_p_local_success;
auto surrogate_p_error = 1.0 - surrogate_p_local_success;
// only valid when p_error is not too small
auto valid = 0 < surrogate_p_error && surrogate_p_error < 1.0;
if (!valid) {
// linear approximation, only precise for small p_error
auto linear_correction = sol.p_error / sol.global_p_error;
surrogate_p_error =
options.maximum_acceptable_error_probability * linear_correction;
};
options.maximum_acceptable_error_probability = surrogate_p_error;
sol = dag->optimize(options);
if (sol.global_p_error <= config.global_p_error) {