github/concrete
1
1
Fork 0
mirror of https://github.com/zama-ai/concrete.git synced 2026-02-09 12:15:09 -05:00
Code Issues Packages Projects Releases Wiki Activity

bug(Lambda): #253 reactivate the bug about Lambda parameter number verification

Browse Source 
[----------] Global test environment tear-down
[==========] 6 tests from 1 test suite ran. (1327 ms total)
[  PASSED  ] 5 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] Lambda_check_param.scalar_tensor_to_tensor_good_number_param

 1 FAILED TEST
  YOU HAVE 3 DISABLED TESTS
This commit is contained in:
rudy
2021-11-18 15:38:51 +01:00
committed by rudy-6-4
parent cc9186d60d
commit 9a09afaa80
2 changed files with 11 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
compiler/lib/Support/Jit.cpp
View File

@@ -55,16 +55,15 @@ JITLambda::create(llvm::StringRef name, mlir::ModuleOp &module,
}
llvm::Error JITLambda::invokeRaw(llvm::MutableArrayRef<void *> args) {
// size_t nbReturn = 0;
// TODO - This check break with memref as we have 5 returns args.
// if (!this->type.getReturnType().isa<mlir::LLVM::LLVMVoidType>()) {
// nbReturn = 1;
// }
// if (this->type.getNumParams() != args.size() - nbReturn) {
// return llvm::make_error<llvm::StringError>(
// "invokeRaw: wrong number of argument",
// llvm::inconvertibleErrorCode());
// }
size_t nbReturn = 0;
if (!this->type.getReturnType().isa<mlir::LLVM::LLVMVoidType>()) {
nbReturn = 1;
}
if (this->type.getNumParams() != args.size() - nbReturn) {
return llvm::make_error<llvm::StringError>(
"invokeRaw: wrong number of argument",
llvm::inconvertibleErrorCode());
}
if (llvm::find(args, nullptr) != args.end()) {
return llvm::make_error<llvm::StringError>(
"invoke: some arguments are null", llvm::inconvertibleErrorCode());

5
compiler/tests/unittest/end_to_end_jit_lambda.cc
View File

@@ -74,8 +74,7 @@ TEST(Lambda_check_param, scalar_tensor_to_scalar) {
ASSERT_EXPECTED_SUCCESS(lambda(1_u64, arg, ARRAY_SIZE(arg)));
}
TEST(Lambda_check_param, scalar_tensor_to_scalar_superfluous_param) {
// DISABLED Note: "terminate called after throwing an instance of 'std::bad_alloc'"
TEST(Lambda_check_param, DISABLED_scalar_tensor_to_scalar_superfluous_param) {
Lambda lambda = checkedJit(R"XXX(
func @main(
%arg0: !HLFHE.eint<1>, %arg1: tensor<2x!HLFHE.eint<1>>) -> !HLFHE.eint<1>
@@ -87,7 +86,7 @@ TEST(Lambda_check_param, scalar_tensor_to_scalar_superfluous_param) {
ASSERT_EXPECTED_FAILURE(lambda(1_u64, arg, ARRAY_SIZE(arg), arg, ARRAY_SIZE(arg)));
}
TEST(Lambda_check_param, scalar_tensor_to_tensor_good_number_param) {
TEST(Lambda_check_param, DISABLED_scalar_tensor_to_tensor_good_number_param) {
Lambda lambda = checkedJit(R"XXX(
func @main(
%arg0: !HLFHE.eint<1>, %arg1: tensor<2x!HLFHE.eint<1>>) -> tensor<2x!HLFHE.eint<1>>