github/concrete
1
1
Fork 0
mirror of https://github.com/zama-ai/concrete.git synced 2026-02-09 03:55:04 -05:00
Code Issues Packages Projects Releases Wiki Activity

feat(compiler): delay the point where futures are waited on, when they are being synchronized back to their parent context, to the point of use.

Browse Source
This commit is contained in:
Antoniu Pop
2022-03-23 13:03:33 +00:00
committed by Antoniu Pop
parent 954b2098c6
commit bca85ea2b6
1 changed files with 5 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
compiler/lib/Dialect/RT/Analysis/LowerDataflowTasksToRT.cpp
View File

@@ -122,15 +122,6 @@ static void replaceAllUsesInDFTsInRegionWith(Value orig, Value replacement,
use.set(replacement);
}
}
static void replaceAllUsesNotInDFTsInRegionWith(Value orig, Value replacement,
Region &region) {
for (auto &use : llvm::make_early_inc_range(orig.getUses())) {
if (!isa<RT::DataflowTaskOp>(use.getOwner()) &&
use.getOwner()->getParentOfType<RT::DataflowTaskOp>() == nullptr &&
region.isAncestor(use.getOwner()->getParentRegion()))
use.set(replacement);
}
}
// TODO: Fix type sizes. For now we're using some default values.
static std::pair<mlir::Value, mlir::Value>
@@ -306,16 +297,13 @@ static void lowerDataflowTaskOp(RT::DataflowTaskOp DFTOp,
for (auto &use : llvm::make_early_inc_range(result.getUses())) {
if (!isa<RT::DataflowTaskOp>(use.getOwner()) &&
use.getOwner()->getParentOfType<RT::DataflowTaskOp>() == nullptr) {
// Wait for this future
// TODO: the wait function should ideally
// be issued as late as possible, but need to identify which
// use comes first.
// Wait for this future before its uses
OpBuilder::InsertionGuard guard(builder);
builder.setInsertionPoint(use.getOwner());
auto af = builder.create<RT::AwaitFutureOp>(
DFTOp.getLoc(), result.getType(), drpp.getResult());
replaceAllUsesNotInDFTsInRegionWith(result, af->getResult(0), opBody);
// We only need to to this once, propagation will hit all
// other uses
break;
assert(opBody.isAncestor(use.getOwner()->getParentRegion()));
use.set(af->getResult(0));
}
}
// All leftover uses (i.e. those within DFTs should use the future)