github/concrete
1
1
Fork 0
mirror of https://github.com/zama-ai/concrete.git synced 2026-02-08 19:44:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

chore(compiler): fix pessimizing-move

Browse Source
This commit is contained in:
Mayeul@Zama
2022-11-02 12:13:39 +01:00
committed by mayeul-zama
parent 39c5d46a50
commit dd62896bc8
3 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
compiler/CMakeLists.txt
View File

@@ -9,10 +9,9 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
# Wouldn't be able to compile LLVM without this on Mac (using either Clang or AppleClang)
if(APPLE)
add_definitions("-Wno-narrowing -Wno-dollar-in-identifier-extension -Wno-string-conversion -Wno-pessimizing-move")
add_definitions("-Wno-narrowing -Wno-dollar-in-identifier-extension -Wno-string-conversion")
else()
add_definitions("-Wall -Wno-pessimizing-move")
add_definitions("-Werror ")
add_definitions("-Wall -Werror")
endif()
# If we are trying to build the compiler with LLVM/MLIR as libraries

16
compiler/include/concretelang/Support/LambdaSupport.h
View File

@@ -50,42 +50,42 @@ inline llvm::Expected<T> typedScalarResult(clientlib::KeySet &keySet,
template <>
inline llvm::Expected<uint64_t> typedResult(clientlib::KeySet &keySet,
clientlib::PublicResult &result) {
return std::move(typedScalarResult<uint64_t>(keySet, result));
return typedScalarResult<uint64_t>(keySet, result);
}
template <>
inline llvm::Expected<int64_t> typedResult(clientlib::KeySet &keySet,
clientlib::PublicResult &result) {
return std::move(typedScalarResult<int64_t>(keySet, result));
return typedScalarResult<int64_t>(keySet, result);
}
template <>
inline llvm::Expected<uint32_t> typedResult(clientlib::KeySet &keySet,
clientlib::PublicResult &result) {
return std::move(typedScalarResult<uint32_t>(keySet, result));
return typedScalarResult<uint32_t>(keySet, result);
}
template <>
inline llvm::Expected<int32_t> typedResult(clientlib::KeySet &keySet,
clientlib::PublicResult &result) {
return std::move(typedScalarResult<int32_t>(keySet, result));
return typedScalarResult<int32_t>(keySet, result);
}
template <>
inline llvm::Expected<uint16_t> typedResult(clientlib::KeySet &keySet,
clientlib::PublicResult &result) {
return std::move(typedScalarResult<uint16_t>(keySet, result));
return typedScalarResult<uint16_t>(keySet, result);
}
template <>
inline llvm::Expected<int16_t> typedResult(clientlib::KeySet &keySet,
clientlib::PublicResult &result) {
return std::move(typedScalarResult<int16_t>(keySet, result));
return typedScalarResult<int16_t>(keySet, result);
}
template <>
inline llvm::Expected<uint8_t> typedResult(clientlib::KeySet &keySet,
clientlib::PublicResult &result) {
return std::move(typedScalarResult<uint8_t>(keySet, result));
return typedScalarResult<uint8_t>(keySet, result);
}
template <>
inline llvm::Expected<int8_t> typedResult(clientlib::KeySet &keySet,
clientlib::PublicResult &result) {
return std::move(typedScalarResult<int8_t>(keySet, result));
return typedScalarResult<int8_t>(keySet, result);
}
template <typename T>

7
compiler/lib/CAPI/Support/CompilerEngine.cpp
View File

@@ -165,7 +165,7 @@ decrypt_result(concretelang::clientlib::KeySet &keySet,
std::unique_ptr<mlir::concretelang::LambdaArgument>>(
keySet, publicResult));
lambdaArgument result_{std::move(*result)};
return std::move(result_);
return result_;
}
MLIR_CAPI_EXPORTED std::unique_ptr<concretelang::clientlib::PublicArguments>
@@ -270,8 +270,7 @@ std::string roundTrip(const char *module) {
retOrErr = ce.compile(
module, mlir::concretelang::CompilerEngine::Target::ROUND_TRIP);
if (!retOrErr) {
os << "MLIR parsing failed: "
<< llvm::toString(std::move(retOrErr.takeError()));
os << "MLIR parsing failed: " << llvm::toString(retOrErr.takeError());
throw std::runtime_error(os.str());
}
@@ -320,7 +319,7 @@ std::vector<uint64_t> lambdaArgumentGetTensorData(lambdaArgument &lambda_arg) {
std::string backingString;
llvm::raw_string_ostream os(backingString);
os << "Couldn't get size of tensor: "
<< llvm::toString(std::move(sizeOrErr.takeError()));
<< llvm::toString(sizeOrErr.takeError());
throw std::runtime_error(os.str());
}
std::vector<uint64_t> data(arg->getValue(), arg->getValue() + *sizeOrErr);