Commit Graph

6467 Commits

Author SHA1 Message Date
Alex Stokes
2aa5bf8384 assert active validator set is larger than sync committee size
ensure set is larger, rather than just equal to
2021-07-01 16:35:03 -07:00
Alex Stokes
060ba633eb Merge pull request #2499 from ethereum/altair-validator-tests
Add some Altair validator guide tests
2021-07-01 10:56:59 -07:00
Hsiao-Wei Wang
bb327d274e Add more Altair validator guide unit tests
Add `test_get_sync_committee_message`

Add `test_get_sync_committee_selection_proof`

Add `always_bls` deco

Add `test_is_sync_committee_aggregator`

Add `test_get_contribution_and_proof` and `test_get_contribution_and_proof_signature` + fixes
2021-07-01 22:49:23 +08:00
Alex Stokes
4f905551c0 Merge pull request #2497 from ethereum/union-debug-utils
encode, decode and randomize ssz Union types
2021-06-24 09:37:49 -07:00
Alex Stokes
44a3113ce1 fix spacing for linter 2021-06-24 09:24:58 -07:00
protolambda
dbf7fbd3d0 encode, decode and randomize ssz Union types 2021-06-24 17:13:36 +02:00
Danny Ryan
85901cdfa7 Merge pull request #2494 from ethereum/bump-version
bump VERSION.txt to 1.1.0-alpha.8
2021-06-23 08:51:31 -06:00
Danny Ryan
989c9620c7 bump VERSION.txt to 1.1.0-alpha.8 2021-06-23 08:32:52 -06:00
Danny Ryan
00afb341de Merge pull request #2479 from mkalinin/randao_in_execution_payload
Add randao to execution payload
2021-06-23 08:30:21 -06:00
Danny Ryan
d774fb6b00 Merge pull request #2491 from ethereum/sync-committee-gossip
optimize sync committee message gossip and caches
2021-06-23 08:15:00 -06:00
Danny Ryan
f2bd21b434 Merge pull request #2492 from ethereum/vbuterin-patch-11
Update merge description to signal more progress
2021-06-22 17:16:51 -06:00
vbuterin
e8136cb62c Update merge description to signal more progress 2021-06-22 18:15:56 -05:00
Danny Ryan
c61eeb8a27 optimize sync committee message gossip and caches 2021-06-22 12:31:02 -06:00
Mikhail Kalinin
e5c01061af Add couple of cosmetic fixes 2021-06-22 14:26:38 +06:00
Mikhail Kalinin
ac19aa3e2d Accept polishing suggested by Justin 2021-06-22 14:23:26 +06:00
Danny Ryan
8107d0d582 Merge pull request #2485 from nisdas/patch-1
Make The Nature of Validator Sync Committee Assignments Clearer
2021-06-21 16:51:11 -05:00
Danny Ryan
fc1012b632 typo 2021-06-21 12:49:41 -06:00
Danny Ryan
a61aa7968d clean up 2021-06-21 12:48:44 -06:00
Mikhail Kalinin
199d6aee58 Merge remote-tracking branch 'origin/dev' into randao_in_execution_payload 2021-06-19 00:28:38 +06:00
Justin
878b15df6a polish merge/beacon-chain.md (#2472)
Polish `merge/beacon-chain.md` with mostly non-substantive changes.

**Non-substantive changes**

* rename `MAX_EXECUTION_TRANSACTIONS` to `MAX_TRANSACTIONS_PER_PAYLOAD`
	- rename "execution transaction" to just "transaction" as per discussion with Danny
* rename `compute_time_at_slot` to `compute_timestamp_at_slot`
	- the function returns a Unix timestamp
	- "timestamp" matches `execution_payload.timestamp`
* be explicit about `ExecutionEngine.execution_state` for clarity
* rename `ExecutionPayload.number` to `ExecutionPayload.block_number`
	- more specific ("number" is pretty vague)
	- consistent with `ExecutionPayload.block_hash`
* rename `new_block` to `on_payload`
	- the `on_` prefix is consistent with other event handlers (e.g. see `on_tick`, `on_block`, `on_attestation` [here](https://github.com/ethereum/eth2.0-specs/blob/dev/specs/phase0/fork-choice.md#handlers))
	- the `_payload` suffix is more to the point given the function accepts an `execution_payload`
	- avoids conflict with `on_block` which is already used in the fork choice
* rework the table of contents for consistency
* order `is_execution_enabled` after `is_transition_completed` and `is_transition_block`
	- `is_execution_enabled` refers to `is_transition_completed` and `is_transition_block`
* rename "transition" to "merge"
	- "transition" is a bit vague—we will have other transitions at future hard forks
	- there is no need for two words to refer to the same concept
* add a bunch of inline comments, e.g. in `process_execution_payload`
* make the `process_execution_payload` signature consistent with the other `process_` functions in `process_block` which take as arguments `state` and `block.body`
* remove `TRANSITION_TOTAL_DIFFICULTY`
	- to be put in `merge/fork-choice.md` where it is used 
* various misc cleanups

**Substantive changes**

* reorder `ExecutionPayload` fields
	- for consistency with yellow paper and Eth1
	- same for `ExecutionPayloadHeader`
	- added comments separating out the execution block header fields from the extra fields (cosmetic)
2021-06-18 11:09:30 +01:00
Diederik Loerakker
903b363c2d Merge pull request #2484 from ericsson49/ericsson49/fix_reset_pending_shard_work
Fix typing problem in `reset_pending_shard_work`
2021-06-17 19:05:05 +02:00
protolambda
dadcb2a06a Merge branch 'dev' into ericsson49/fix_reset_pending_shard_work 2021-06-17 18:54:29 +02:00
Diederik Loerakker
c68ce56407 Merge pull request #2483 from ericsson49/ericsson49/fix_append_in_process_shard_header
Fix typing problem: append is invoked on a ShardWork instance
2021-06-17 18:50:40 +02:00
Diederik Loerakker
691b15a2ed Merge pull request #2482 from ericsson49/ericsson49/fix_shard_work_status_chage
Fix typo: `change()` should be invoked on `ShardWork.status`
2021-06-17 18:49:08 +02:00
Mikhail Kalinin
6e86d8a696 Rename randao->random, other fixes as per review 2021-06-17 21:20:17 +06:00
Nishant Das
67f1c2c2bd Update validator.md 2021-06-17 23:05:23 +08:00
ericsson
22b2a73615 convert int to CommitteeIndex when passing to get_beacon_committee 2021-06-16 19:07:24 +03:00
ericsson
5b4f89875c use List[PendingShardHeader,...] instead of MutableSequence, since remerkleable.List does not implement the latter 2021-06-16 14:06:17 +03:00
ericsson
d83ca352d5 Fix typing problem: append is invoked on a ShardWork instance 2021-06-16 13:33:56 +03:00
ericsson
27889860f0 fix typo: sometimes change() invoked on ShardWork itself, should be invoked on its status field 2021-06-16 12:03:20 +03:00
Mikhail Kalinin
cc20b80103 Fix linter, add more test helpers 2021-06-15 14:55:06 +06:00
Danny Ryan
a63916a6ec Merge pull request #2478 from ethereum/attester-proposer-slashing
Add a few missing slashing tests
2021-06-14 15:09:02 -06:00
Danny Ryan
5c1cb153aa Merge branch 'dev' into attester-proposer-slashing 2021-06-14 15:08:10 -06:00
Mikhail Kalinin
2e87a6b44e Apply review comments 2021-06-11 22:50:11 +06:00
Mikhail Kalinin
7d617bc7c0 Fix timestamp passed to produce_execution_payload 2021-06-11 22:46:24 +06:00
Mikhail Kalinin
95775e1b90 Add randao to execution payload 2021-06-11 16:05:19 +06:00
Danny Ryan
973a874105 Merge pull request #2477 from ethereum/fix-proposer-slashing-test
fix mismatched proposer test names
2021-06-10 10:04:38 -06:00
Danny Ryan
a5762cbad8 add attestesr slashing for proposer, and some future slashing tests woo 2021-06-09 16:56:32 -06:00
Danny Ryan
1ade07d705 fix mismatched proposer test names 2021-06-09 16:31:20 -06:00
Alex Stokes
a553e3b18e Merge pull request #2476 from ethereum/fix-msg-id-parenthesis
add missing parenthesis
2021-06-08 12:53:56 -07:00
protolambda
5140b59c57 add missing parenthesis 2021-06-08 21:51:26 +02:00
Diederik Loerakker
8f8b5ab648 Merge pull request #2475 from ralexstokes/discriminate-sync-comm-msg
Add `message.topic` to gossipsub `message-id` in Altair
2021-06-08 21:47:06 +02:00
Alex Stokes
a343680fd4 Add implementation note on message id fn 2021-06-08 14:29:08 -05:00
Alex Stokes
f60f13964c Harden topic serialization 2021-06-08 14:15:57 -05:00
Alex Stokes
25a2e3463e Update specs/altair/p2p-interface.md
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
2021-06-08 12:06:02 -07:00
Danny Ryan
db2339e1c9 Merge pull request #2474 from ralexstokes/clarify-altair-p2p-conditions
Clarify p2p validation conditions for Altair sync committees
2021-06-08 12:47:06 -06:00
Alex Stokes
d64b4e7d24 Add message.topic to gossipsub message-id in Altair 2021-06-08 13:44:06 -05:00
Alex Stokes
c7980d3cd0 Clarify p2p validation conditions for Altair sync committees 2021-06-08 13:34:16 -05:00
Danny Ryan
5d9d786499 Merge pull request #2462 from mkalinin/merge-transition-with-dynamic-ttd
Merge transition process with computed transition total difficulty
2021-06-08 09:55:10 -06:00
Danny Ryan
761c77f9a0 Merge pull request #2470 from ethereum/bump-version
bump VERSION.txt to v1.1.0-alpha.7
2021-06-08 08:31:47 -06:00