Commit Graph

4810 Commits

Author SHA1 Message Date
Danny Ryan
d6435d0cbf Merge branch 'dev' into dankrad-custody-256bit 2020-06-01 18:49:11 -06:00
Danny Ryan
3a4db69a20 Merge branch 'dev' into dankrad-custody-256bit 2020-06-01 18:45:22 -06:00
Hsiao-Wei Wang
09d8636e7e Merge pull request #1855 from ethereum/hwwhww/phase1_refactor_part2
Some phase1 refactoring - part2
2020-06-01 17:54:35 +08:00
Hsiao-Wei Wang
31127b7024 Merge branch 'dev' into hwwhww/phase1_refactor_part2 2020-06-01 17:50:49 +08:00
Hsiao-Wei Wang
6317bd68aa PR feedback from Danny
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2020-06-01 17:47:47 +08:00
Hsiao-Wei Wang
8e5db1b49f Merge pull request #1856 from ethereum/hwwhww/verify_empty_shard_transition
Rework `Shard transition processing`
2020-06-01 17:47:00 +08:00
Hsiao-Wei Wang
8f570b461d Merge pull request #1854 from ethereum/hwwhww/phase1_refactor
Some phase1 refactoring
2020-06-01 17:46:16 +08:00
Danny Ryan
82f9f3e1cd Merge pull request #1859 from ethereum/ralexstokes-patch-1
Update fork choice spec comment for clarity
2020-05-31 14:13:58 -06:00
Alex Stokes
437b2ebb90 Update fork choice spec comment for clarity
I think this change more clearly specifies the intended behavior. Given the terseness of the spec's code representation, I think we should aim for as much clarity as possible.
2020-05-29 18:16:06 -07:00
Hsiao-Wei Wang
327deb40b2 Adjust function blocks 2020-05-30 03:14:51 +08:00
Hsiao-Wei Wang
cceeab2657 Combine process_crosslinks and verify_empty_shard_transition into process_shard_transitions 2020-05-30 03:13:20 +08:00
Hsiao-Wei Wang
9b9507c138 Merge branch 'dev' into hwwhww/phase1_refactor_part2 2020-05-30 03:11:28 +08:00
Hsiao-Wei Wang
f70224b84e Extract compute_committee_source_epoch 2020-05-30 03:09:42 +08:00
Hsiao-Wei Wang
b16e6d7a86 PR feedback from Danny
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2020-05-29 12:58:19 +08:00
Hsiao-Wei Wang
bd9f983eea Minor fix 2020-05-29 02:20:38 +08:00
Danny Ryan
4cbe51b958 Merge pull request #1853 from ethereum/hwwhww/shard_block
Add `shard` field to `ShardBlock`
2020-05-28 12:04:04 -06:00
Hsiao-Wei Wang
8ae7f5b6fa Refactor is_valid_indexed_attestation: extract verify_attestation_custody 2020-05-29 01:24:17 +08:00
Hsiao-Wei Wang
7509ecb742 Add comments, minor refactoring 2020-05-29 00:13:08 +08:00
Hsiao-Wei Wang
19262888e4 Rename verify_shard_transition_false_positives to verify_empty_shard_transition 2020-05-28 21:55:49 +08:00
Hsiao-Wei Wang
8c9bbc48d8 Rework is_shard_attestation
Change it to `is_on_time_attestation` so that it could be reused in
`validate_attestation`.
2020-05-28 21:49:36 +08:00
Hsiao-Wei Wang
ca48963032 Rename head_shard_root to shard_head_root 2020-05-28 21:38:11 +08:00
Hsiao-Wei Wang
c437578280 Add shard field to ShardBlock 2020-05-28 21:32:27 +08:00
Danny Ryan
05b1d913cb Merge pull request #1847 from ethereum/networking-misc-fixes
Update link so gossipsub encodings match the correct section
2020-05-26 14:29:04 -06:00
Alex Stokes
75633cfcf1 Update link so gossipsub encodings match the correct section 2020-05-26 11:00:02 -07:00
Danny Ryan
8eb1d2e940 Merge pull request #1844 from ericsson49/ericsson49/fix_shard_state_transition
`compute_shard_transition_digest` expects `Root` as a fourth parameter
2020-05-26 10:17:55 -06:00
Danny Ryan
d020d49f09 Merge pull request #1842 from ethereum/phase1_on_time_sign_indexed_attestation
Fix phase1 on-time sign_indexed_attestation
2020-05-26 10:12:00 -06:00
Danny Ryan
753a25e5db Merge pull request #1843 from terencechain/patch-99
Use `compute_previous_slot` for `slot - 1` occurrences
2020-05-26 10:02:14 -06:00
Danny Ryan
0520b1c8e3 Merge pull request #1845 from aliatiia/patch-1
broken link
2020-05-26 10:01:03 -06:00
Ali Atiia
75787d92a8 broken link
broken link to custory-game.md
2020-05-25 16:45:44 -04:00
ericsson
d3c26d6b8b compute_shard_transition_digest expects Root as a fourth parameter 2020-05-25 18:45:38 +03:00
terence tsao
ce1d22d71c Use helper compute_previous_slot 2020-05-23 15:22:49 -07:00
Hsiao-Wei Wang
5e8457e62d Fix phase1 on-time sign_indexed_attestation 2020-05-23 21:53:55 +08:00
Danny Ryan
7770accf96 Merge pull request #1803 from ethereum/fast-bls-option
BLS options for pyspec
2020-05-20 14:39:49 -06:00
protolambda
87005c6f10 milagro bls 1.3 with improved error handling 2020-05-20 22:32:47 +02:00
Diederik Loerakker
f4991ce5bb Merge pull request #1836 from ethereum/disallow-rewind-votes
ensure can't undo progress with eth1data voting
2020-05-20 22:08:33 +02:00
Danny Ryan
61336a9c0b add deposit_root to validator unit tets 2020-05-20 14:03:16 -06:00
Danny Ryan
96f785e84b ensure only forward progress with eth1data voting 2020-05-20 13:56:43 -06:00
Hsiao-Wei Wang
d92efdf071 Should have signed the attestions in test_filtered_block_tree test 2020-05-21 03:02:02 +08:00
Danny Ryan
aa6352608e Merge pull request #1835 from ethereum/strict-block-range
Strict block range (Rebase and extend #1827)
2020-05-20 13:00:29 -06:00
Hsiao-Wei Wang
763d74bbf5 Just learned bls was disabled by default; fixing the tests 2020-05-21 02:52:24 +08:00
protolambda
522e34efcf Fix markdown, use multiple lines for change-control, and add step >= 1 case 2020-05-20 20:46:08 +02:00
Danny Ryan
a6d4566f51 Merge pull request #1834 from ethereum/clarify-genesis-safety
clarify that eth1 block follow distance for genesis
2020-05-20 12:44:29 -06:00
protolambda
59a43142c2 Rebased on latest BlocksByRange spec, fix conflicts, clarify single chain, even with higher step 2020-05-20 20:39:52 +02:00
Jacek Sieka
a29cbebc0e cover step parameter in stricter range request 2020-05-20 20:29:43 +02:00
Jacek Sieka
607e23949c require blocks to be ordered consecutively in block range request
Per the spec, if I request range 5-10, it is permissible for a client to
answer with block 7, 9 - even if the blocks 5, 6 and 8 exist.

Because blocks 7 and 9 cannot be validated as they arrive in such a
request, it seems better to close this gap - this update adds the spec
language that forbids well-behaving clients from answering this way.
2020-05-20 20:29:37 +02:00
Danny Ryan
4ac2fc7eff add missing column description fo SECONDS_PER_ETH1_BLOCK
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
2020-05-20 12:28:08 -06:00
Hsiao-Wei Wang
db1a90d2ee test_success_surround changes the signing data of attestation, so it should be never_bls 2020-05-21 02:05:22 +08:00
Hsiao-Wei Wang
f72d14a747 Bump milagro_bls_binding to 1.2.0
Also verify it in BLS test generator
2020-05-21 01:37:12 +08:00
Danny Ryan
7cb8e5e8f3 Merge pull request #1830 from ethereum/neutral-rewards
Ensure balances remain unchanged for optimal validators during leak
2020-05-20 11:15:27 -06:00
Danny Ryan
c9f21f1f43 clarify that eth1 blocks must be at a safe fllow distance before being considered for genesis 2020-05-20 10:44:08 -06:00