Commit Graph

3143 Commits

Author SHA1 Message Date
vbuterin
dbb697dadd Small update to typing in BLS spec file
[uint384] -> Tuple[uint384, uint384]
2019-06-26 19:40:11 -04:00
Diederik Loerakker
d587c4fe61 Critical fix: introduce back total-value check (#1220)
This was dropped in a376b6607f, as improvement in dust checking.
Now that dust-checking is done, we still need to check if the sender has the minimum value, as decrease balance just clips to 0.
See be86f966f8 for older dust-creation problem work around, which was dropped in the above.

The bug enabled you to transfer your full balance to someone else, and pay the same amount in fee, possibly to a puppet proposer to collect back funds.
Effectively enabling printing of money. Silly bug, good to fix and introduce tests for.
2019-06-26 20:21:17 +01:00
Danny Ryan
ab012b8adf Merge pull request #1216 from ethereum/fix-type-aliasing
Change uint aliases to just be subclasses
2019-06-25 14:45:05 -06:00
Danny Ryan
fbb284c86b Merge pull request #1215 from ethereum/ralexstokes-patch-3
Update 0_beacon-chain.md
2019-06-25 14:10:31 -06:00
protolambda
2c6f4f2597 update validator_registry -> validators missed case 2019-06-25 19:33:24 +02:00
protolambda
3b5c7f243a type hint uint input 2019-06-25 19:32:49 +02:00
protolambda
d90d56c610 Change uint aliases to just be subclasses, do not override init with no-op 2019-06-25 18:42:34 +02:00
Alex Stokes
4986311d5b Update 0_beacon-chain.md
fix typo w/ refactor
2019-06-25 10:24:14 -06:00
Danny Ryan
df2a9e1b54 Merge pull request #1180 from ethereum/list-rework
pyspec-SSZ: lists-rework (enable static generalized indices) + fully python class based now.
2019-06-25 07:38:50 -06:00
JSON
20602bc92b phase 0 doc standardization b4 spec freeze (#1212) 2019-06-25 14:32:56 +01:00
Alex Stokes
37b1872634 Remove duplicate custom type definitions (#1214)
Seems to be an accidental duplication of the type defs
2019-06-25 14:30:59 +01:00
protolambda
054a157953 get rid of TypingList, add MutableSequence 2019-06-25 02:58:10 +02:00
Diederik Loerakker
45dbf5a107 Remove old Deltas reference
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-06-25 02:41:02 +02:00
protolambda
a5b7564c5b hash-tree-root tests 2019-06-25 02:37:05 +02:00
Danny Ryan
b5581983f3 Merge pull request #1213 from ethereum/ralexstokes-patch-2
Clarify comment on phase 0 transfers
2019-06-24 16:43:50 -06:00
Alex Stokes
82167ff0a3 Clarify comment on phase 0 transfers
The comment seems to imply conjunction over each case, but the code implies disjunction; at the very least it is ambiguous.

This PR makes the comment less ambiguous.
2019-06-24 15:40:37 -07:00
protolambda
9fb5806764 be explicit about input for balance sum 2019-06-25 00:24:13 +02:00
protolambda
81a2c84a68 Merge branch 'list-rework' of https://github.com/ethereum/eth2.0-specs into list-rework 2019-06-24 23:59:22 +02:00
protolambda
8b88c3f43c Merge remote-tracking branch 'origin' into list-rework 2019-06-24 23:58:00 +02:00
protolambda
5989e5cd23 use Bool as base name, make Bit an alias 2019-06-24 23:56:26 +02:00
protolambda
c73417b4ca deserialize-basic detail, make subclass 2019-06-24 23:40:47 +02:00
protolambda
82ae180490 clean up list limit constants 2019-06-24 23:38:36 +02:00
Danny Ryan
1972ccaaf3 Merge branch 'dev' into list-rework 2019-06-24 13:29:55 -06:00
protolambda
1408a1ee0d undo tuple wrapping 2019-06-23 00:17:54 +02:00
protolambda
a5a2e29dfe remove unnecessary argument, typing is based on values fully now 2019-06-22 22:15:42 +02:00
protolambda
da858f1aae fix int encoding, fix list randomization size limit. 2019-06-22 21:49:42 +02:00
protolambda
9befe09f82 test merkleize chunks 2019-06-22 21:27:56 +02:00
protolambda
0249cf651e fix lint, and update encoder to handle the few imported types well 2019-06-22 20:04:17 +02:00
protolambda
47034a6c8c fix imports in helper test file 2019-06-22 19:59:53 +02:00
protolambda
e873bbd73b support list casting 2019-06-22 19:59:15 +02:00
protolambda
dd5ad2e2c5 remove unnecessary (and now outdated) type hints, update List encoding for generators 2019-06-22 19:48:06 +02:00
protolambda
f95e7315b4 fix get_active_validator_indices typing usage 2019-06-22 18:34:33 +02:00
protolambda
00aae07d46 type annotation clean up 2019-06-22 18:12:42 +02:00
Diederik Loerakker
b007d5aa92 Add note on default zero-values, and be explicit with state-root (#1208)
* Add note on default zero-values, and be explicit with state-root
2019-06-22 17:38:30 +02:00
protolambda
16093eb8ce Merge branch 'dev' into list-rework 2019-06-22 17:11:59 +02:00
Diederik Loerakker
c86108de00 Merge pull request #1207 from ethereum/fix_make_lint
Fix `make lint`
2019-06-22 17:07:00 +02:00
Justin Drake
1e1a3e5311 Avoid substraction in comparison 2019-06-22 07:34:02 +02:00
Justin Drake
613380bff4 Shorter in-line comments 2019-06-22 07:29:25 +02:00
Hsiao-Wei Wang
183fa3c776 Make linter happy 2019-06-21 23:09:11 -06:00
Hsiao-Wei Wang
99df7da94a Add && between the commands 2019-06-21 22:53:02 -06:00
protolambda
0b0e9a51d7 Merge branch 'dev' into list-rework 2019-06-21 23:44:01 +02:00
Diederik Loerakker
65bcb8884f Merge pull request #1204 from ethereum/minimal_max-epochs-per-crosslink
reduce MAX_EPOCHS_PER_CROSSLINK in minimal config
2019-06-21 23:42:11 +02:00
Danny Ryan
e15a649f37 reduce MAX_EPOCHS_PER_CROSSLINK in minimal config for testing purposes 2019-06-21 15:34:36 -06:00
Danny Ryan
8f99741344 remove commented old code 2019-06-21 14:47:18 -06:00
Danny Ryan
c09e45c5fc fix rule_4 underflow and split out genesis finality test 2019-06-21 14:45:15 -06:00
Hsiao-Wei Wang
f55499c0ba Fix Gwei value table (#1203) 2019-06-21 14:30:22 -06:00
Danny Ryan
d463ada754 Merge branch 'dev' into list-rework 2019-06-21 14:18:45 -06:00
Danny Ryan
f12c32a690 Xdist tests for parallelism (#1201)
* add xdist parallelization

* reduce circleci cpus to 8

* reduce cpus to 4

* reduce circleci cpus to 2

* circleci back to 4 cpus
2019-06-21 14:18:28 -06:00
protolambda
d1fa3acb27 remove unused dependency 2019-06-21 21:27:26 +02:00
protolambda
80c40f5e09 merge dev, resolve minor merge conflicts 2019-06-21 21:22:23 +02:00