github/context-mod
1
1
Fork 0
mirror of https://github.com/FoxxMD/context-mod.git synced 2026-04-19 03:00:07 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix check cache result behavior

Browse Source 
* Don't set result in cache if it already exists
* Fix resource manager init issue with cache manager?
* Make check cache logging statements clearer
This commit is contained in:
FoxxMD
2021-08-03 14:25:11 -04:00
parent ad45f75267
commit 045e2c1d33
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Check/index.ts
View File

@@ -177,7 +177,7 @@ export abstract class Check implements ICheck {
// check cache results
const cacheResult = await this.getCacheResult(item);
if(cacheResult !== undefined) {
this.logger.verbose(`Skipping rules run because Check Result found in cache: ${boolToString(cacheResult)}`);
this.logger.verbose(`Skipping rules run because result was found in cache, Check Triggered Result: ${cacheResult}`);
return [cacheResult, allRuleResults];
}

11
src/Subreddit/SubredditResources.ts
View File

@@ -332,7 +332,6 @@ export class SubredditResources {
if (this.filterCriteriaTTL > 0) {
let item = i;
let states = s;
debugger;
// optimize for submission only checks on comment item
if (item instanceof Comment && states.length === 1 && Object.keys(states[0]).length === 1 && (states[0] as CommentState).submissionState !== undefined) {
// get submission
@@ -488,7 +487,13 @@ export class SubredditResources {
...checkConfig
}
const hash = objectHash.sha1(criteria);
return await this.cache.set(hash, result, { ttl });
// don't set if result is already cached
if(undefined !== await this.cache.get(hash)) {
this.logger.debug(`Check result already cached for User ${item.author.name} on Submission ${item.link_id}`);
} else {
await this.cache.set(hash, result, { ttl });
this.logger.debug(`Cached check result '${result}' for User ${item.author.name} on Submission ${item.link_id} for ${ttl} seconds`);
}
}
async generateFooter(item: Submission | Comment, actionFooter?: false | string) {
@@ -510,7 +515,7 @@ class SubredditResourcesManager {
authorTTL: number = 10000;
enabled: boolean = true;
modStreams: Map<string, SPoll<Snoowrap.Submission | Snoowrap.Comment>> = new Map();
defaultCache: Cache = createCacheManager({store: 'none'});
defaultCache!: Cache;
cacheType: string = 'none';
cacheHash!: string;
ttlDefaults!: Required<TTLConfig>;