github/context-mod
1
1
Fork 0
mirror of https://github.com/FoxxMD/context-mod.git synced 2026-05-11 03:00:42 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(item filter): Fix unknown value results

Browse Source 
* For unknown value on activity use correct reason and add to property map
* Test for undefined property in property map (shouldn't happen)
This commit is contained in:
FoxxMD
2022-03-10 13:04:16 -05:00
parent d632364c7d
commit 45be87a72a
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Subreddit/SubredditResources.ts
View File

@@ -1047,14 +1047,10 @@ export class SubredditResources {
const keys = Object.keys(propResultsMap) as (keyof (SubmissionState & CommentState))[]
let shouldContinue;
try {
for(const k of keys) {
const itemOptVal = definedStateCriteria[k];
shouldContinue = undefined;
switch(k) {
case 'submissionState':
if(isSubmission(item)) {
@@ -1284,17 +1280,23 @@ export class SubredditResources {
break;
}
default:
// @ts-ignore
const val = item[k];
if(val === undefined) {
log.warn(`Value for ${k} cannot be undefined`);
} else if(propResultsMap[k] === undefined) {
// this shouldn't happen
if(propResultsMap[k] === undefined) {
log.warn(`State criteria property ${k} was not found in property map?? This shouldn't happen`);
} else if(val === undefined) {
let defaultWarn = `Tried to test for Activity property '${k}' but it did not exist. Check the spelling of the property.`;
if(!item.can_mod_post) {
defaultWarn =`Tried to test for Activity property '${k}' but it did not exist. This Activity is not in a subreddit the bot can mod so it may be that this property is only available to mods of that subreddit. Or the property may be misspelled.`;
}
log.debug(defaultWarn);
propResultsMap[k]!.found = 'undefined';
propResultsMap[k]!.reason = defaultWarn;
} else {
propResultsMap[k]!.found = val;
propResultsMap[k]!.passed = val === itemOptVal;