github/core
1
1
Fork 0
mirror of https://github.com/lens-protocol/core.git synced 2026-01-10 06:38:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

feat: Credit providers can mint less than 5-char length and have infinite credits

Browse Source 
Co-authored-by: Victor Naumik <vicnaum@gmail.com>
This commit is contained in:
donosonaumczuk
2024-02-28 16:11:45 -03:00
parent ca749e9b8a
commit 0696702508
2 changed files with 73 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
contracts/misc/PermissionlessCreator.sol
View File

@@ -218,7 +218,7 @@ contract PermissionlessCreator is ImmutableOwnable {
}
function _validateHandleLength(string calldata handle) private view {
if (bytes(handle).length < _handleLengthMin) {
if (!_isCreditProvider[msg.sender] && bytes(handle).length < _handleLengthMin) {
revert HandleLengthNotAllowed();
}
}
@@ -230,6 +230,10 @@ contract PermissionlessCreator is ImmutableOwnable {
}
function _spendCredit(address account) private {
if (_isCreditProvider[msg.sender]) {
// Credit providers do not need credits.
return;
}
_credits[account] -= 1;
emit CreditBalanceChanged(account, _credits[account], block.timestamp);
}

68
test/misc/PermissionlessCreatorTest.t.sol
View File

@@ -1011,3 +1011,71 @@ contract PermissionlessCreatorTest_Credits is PermissionlessCreatorTestBase {
assertEq(permissionlessCreator.getCreditBalance(targetAddress), balanceBefore + addBalance - subBalance);
}
}
contract PermissionlessCreatorTest_CreditProviders is PermissionlessCreatorTestBase {
address creditProvider = makeAddr('CREDIT_PROVIDER');
function setUp() public override {
super.setUp();
vm.prank(permissionlessCreatorOwner);
permissionlessCreator.addCreditProvider(creditProvider);
}
// Scenarios
function testCreateProfile_byCreditProvider(address to) public {
vm.assume(to != address(0));
Types.CreateProfileParams memory createProfileParams = Types.CreateProfileParams({
to: to,
followModule: address(0),
followModuleInitData: ''
});
address[] memory delegates = new address[](1);
delegates[0] = makeAddr('DE0');
vm.prank(creditProvider);
uint256 profileId = permissionlessCreator.createProfileUsingCredits(createProfileParams, delegates);
assertEq(hub.ownerOf(profileId), to);
assertTrue(hub.isDelegatedExecutorApproved(profileId, delegates[0]));
}
function testCreateHandle_byCreditProvider(address to) public {
vm.assume(to != address(0));
string memory handle = 'q4w';
vm.prank(creditProvider);
uint256 handleId = permissionlessCreator.createHandleUsingCredits(to, handle);
assertEq(lensHandles.ownerOf(handleId), to);
}
function testCreateProfileWithHandle_byCreditProvider(address to) public {
vm.assume(to != address(0));
Types.CreateProfileParams memory createProfileParams = Types.CreateProfileParams({
to: to,
followModule: address(0),
followModuleInitData: ''
});
string memory handle = 'q4w';
address[] memory delegates = new address[](1);
delegates[0] = makeAddr('DE0');
vm.prank(creditProvider);
(uint256 profileId, uint256 handleId) = permissionlessCreator.createProfileWithHandleUsingCredits(
createProfileParams,
handle,
delegates
);
assertEq(hub.ownerOf(profileId), to);
assertTrue(hub.isDelegatedExecutorApproved(profileId, delegates[0]));
assertEq(lensHandles.ownerOf(handleId), to);
}
}