github/core
1
1
Fork 0
mirror of https://github.com/lens-protocol/core.git synced 2026-04-22 03:02:03 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #11 from aave/fix/remove-followed-event

Browse Source
This commit is contained in:
Zer0dot
2022-02-09 10:29:09 -05:00
committed by GitHub
parent 7c9a51940a f3abcec1e1
commit 1012dcf113
3 changed files with 3 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
contracts/libraries/Events.sol
View File

@@ -270,15 +270,6 @@ library Events {
uint256 timestamp
);
/**
* @dev Emitted upon a successful follow action.
*
* @param follower The address following the profile.
* @param profileIds The profile token ID array of the profiles being followed.
* @param timestamp The current block timestamp.
*/
event Followed(address indexed follower, uint256[] profileIds, uint256 timestamp);
/**
* @dev Emitted when a collectNFT clone is deployed using a lazy deployment pattern.
*

4
contracts/libraries/InteractionLogic.sol
View File

@@ -46,7 +46,8 @@ library InteractionLogic {
if (profileIds.length != followModuleDatas.length) revert Errors.ArrayMismatch();
for (uint256 i = 0; i < profileIds.length; ++i) {
string memory handle = _profileById[profileIds[i]].handle;
if (_profileIdByHandleHash[keccak256(bytes(handle))] == 0) revert Errors.TokenDoesNotExist();
if (_profileIdByHandleHash[keccak256(bytes(handle))] == 0)
revert Errors.TokenDoesNotExist();
address followModule = _profileById[profileIds[i]].followModule;
@@ -79,7 +80,6 @@ library InteractionLogic {
);
}
}
emit Events.Followed(follower, profileIds, block.timestamp);
}
/**

3
test/other/events.spec.ts
View File

@@ -451,9 +451,8 @@ makeSuiteCleanRoom('Events', function () {
const expectedName = MOCK_PROFILE_HANDLE + '-Follower';
const expectedSymbol = getAbbreviation(MOCK_PROFILE_HANDLE) + '-Fl';
expect(receipt.logs.length).to.eq(6);
expect(receipt.logs.length).to.eq(5);
matchEvent(receipt, 'FollowNFTDeployed', [FIRST_PROFILE_ID, followNFT, await getTimestamp()]);
matchEvent(receipt, 'Followed', [userTwoAddress, [FIRST_PROFILE_ID], await getTimestamp()]);
matchEvent(receipt, 'BaseInitialized', [expectedName, expectedSymbol, await getTimestamp()]);
matchEvent(receipt, 'Transfer', [ZERO_ADDRESS, userTwoAddress, 1], lensHubImpl);
matchEvent(receipt, 'FollowNFTTransferred', [