github/core
1
1
Fork 0
mirror of https://github.com/lens-protocol/core.git synced 2026-04-22 03:02:03 -04:00
Code Issues Packages Projects Releases Wiki Activity

misc: Fork tests in progress

Browse Source 
Co-authored-by: Victor Naumik <vicnaum@gmail.com>
This commit is contained in:
donosonaumczuk
2023-07-25 18:01:17 +01:00
parent 0c93d854fd
commit 637d7a72c7
5 changed files with 109 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.env.example
View File

@@ -9,3 +9,8 @@ TENDERLY_PROJECT=
TENDERLY_USERNAME=
TENDERLY_FORK_ID=
TENDERLY_HEAD_ID=
# Forking setup (uncomment to test using a fork)
# TESTING_FORK=mainnet
# TESTING_FORK_CURRENT_VERSION=1
# TESTING_FORK_BLOCK=45504400

42
contracts/misc/ProfileCreationProxy.sol
View File

@@ -33,16 +33,19 @@ contract ProfileCreationProxy is ImmutableOwnable {
TOKEN_HANDLE_REGISTRY = ITokenHandleRegistry(tokenHandleRegistry);
}
function proxyCreateProfile(
Types.CreateProfileParams calldata createProfileParams
) external onlyOwner returns (uint256) {
function proxyCreateProfile(Types.CreateProfileParams calldata createProfileParams)
external
onlyOwner
returns (uint256)
{
return ILensHub(LENS_HUB).createProfile(createProfileParams);
}
function proxyCreateProfileWithHandle(
Types.CreateProfileParams memory createProfileParams,
string calldata handle
) external onlyOwner returns (uint256, uint256) {
function proxyCreateProfileWithHandle(Types.CreateProfileParams memory createProfileParams, string calldata handle)
external
onlyOwner
returns (uint256, uint256)
{
// Check if LensHubV1 already has a profile with this handle that was not migrated yet:
bytes32 handleHash = keccak256(bytes(string.concat(handle, '.lens')));
if (LensV2Migration(LENS_HUB).getProfileIdByHandleHash(handleHash) != 0) {
@@ -71,28 +74,3 @@ contract ProfileCreationProxy is ImmutableOwnable {
return LENS_HANDLES.mintHandle(to, handle);
}
}
/*
APPROACH #1: Fork LensV1 from existing chain, deploy LensV2, upgrade, and test the migrations
- It's not clean, controllable by us, unless we create new profiles in V1 and new follows (non deterministic)
APPROACH #2: Deploy LensV1, add some profiles (then some follows too), deploy LensV2, upgrade, and test the migrations
- We need a repo of V1 (which we already import)
in TestSetup setup() we need:
- if fork: we get Lens V1 addresses
- if not fork: we deploy Lens V1 addresses
ONE APPROACH:
onV2 modifier:
- do an upgrade from Lens V1 to V2
without onV2 modifier we test on V1:
- Upgrade (we try to upgrade V1 -> V2 in test)
- Migrations (we do what we need on V1, and then upgrade to V2)
ANOTHER APPROACH:
BaseTest function upgradeToV2():
- will upgrade the V1 contracts to V2 whenever we need
*/

124
test/base/TestSetup.t.sol
View File

@@ -25,7 +25,6 @@ import {StorageLib} from 'contracts/libraries/StorageLib.sol';
import 'test/Constants.sol';
import {LensHandles} from 'contracts/namespaces/LensHandles.sol';
import {TokenHandleRegistry} from 'contracts/namespaces/TokenHandleRegistry.sol';
import {LensV2UpgradeContract} from 'contracts/misc/LensV2UpgradeContract.sol';
contract TestSetup is Test, ForkManagement, ArrayHelpers {
using stdJson for string;
@@ -77,28 +76,6 @@ contract TestSetup is Test, ForkManagement, ArrayHelpers {
ModuleGlobals moduleGlobals;
LensHandles lensHandles;
TokenHandleRegistry tokenHandleRegistry;
LensV2UpgradeContract lensV2UpgradeContract;
// TODO: Avoid constructors in favour of setUp function - Failing asserts in constructor won't make the test fail!
constructor() {
if (bytes(forkEnv).length > 0) {
loadBaseAddresses(forkEnv);
} else {
deployBaseContracts();
}
///////////////////////////////////////// Start governance actions.
vm.startPrank(governance);
if (hub.getState() != Types.ProtocolState.Unpaused) {
hub.setState(Types.ProtocolState.Unpaused);
}
// Whitelist the test contract as a profile creator
hub.whitelistProfileCreator(address(this), true);
vm.stopPrank();
///////////////////////////////////////// End governance actions.
}
function loadBaseAddresses(string memory targetEnv) internal virtual {
console.log('targetEnv:', targetEnv);
@@ -145,7 +122,9 @@ contract TestSetup is Test, ForkManagement, ArrayHelpers {
console.log('LensHandles key does not exist');
if (forkVersion == 1) {
console.log('No LensHandles address found - deploying new one');
address lensHandlesImpl = address(new LensHandles(governance, address(hubAsProxy)));
address lensHandlesImpl = address(
new LensHandles(governance, address(hubAsProxy), HANDLE_GUARDIAN_COOLDOWN)
);
vm.label(lensHandlesImpl, 'LENS_HANDLES_IMPL');
// TODO: Replace deployer owner with proxyAdmin.
@@ -181,19 +160,66 @@ contract TestSetup is Test, ForkManagement, ArrayHelpers {
}
}
// LensV2UpgradeContract
if (keyExists(string(abi.encodePacked('.', targetEnv, '.LensV2UpgradeContract')))) {
lensV2UpgradeContract = LensV2UpgradeContract(
json.readAddress(string(abi.encodePacked('.', targetEnv, '.LensV2UpgradeContract')))
);
} else {
// TODO: Replace deployer with Proxy Upgrade Contract owner - whoever it is
lensV2UpgradeContract = new LensV2UpgradeContract(proxyAdmin, governance, deployer, address(hubAsProxy));
vm.label(lensV2UpgradeContractImpl, 'LENS_V2_UPGRADE_CONTRACT_IMPL');
if (forkVersion == 1) {
upgradeToV2();
}
vm.startPrank(deployer);
// Deploy the MockActionModule.
mockActionModule = new MockActionModule();
vm.label(address(mockActionModule), 'MOCK_ACTION_MODULE');
// Deploy the MockReferenceModule.
mockReferenceModule = new MockReferenceModule();
vm.label(address(mockReferenceModule), 'MOCK_REFERENCE_MODULE');
vm.stopPrank();
///////////////////////////////////////// End deployments.
// Start governance actions.
vm.startPrank(governance);
// Whitelist the MockActionModule.
hub.whitelistActionModule(address(mockActionModule), true);
// Whitelist the MockReferenceModule.
hub.whitelistReferenceModule(address(mockReferenceModule), true);
// End governance actions.
vm.stopPrank();
console.log('ChainId in TestSetup.loadBaseAddresses: ', block.chainid);
}
function upgradeToV2() internal {}
function upgradeToV2() internal virtual {
// Precompute needed addresses.
address followNFTImplAddr = computeCreateAddress(deployer, vm.getNonce(deployer) + 1);
address legacyCollectNFTImplAddr = computeCreateAddress(deployer, vm.getNonce(deployer) + 2);
vm.startPrank(deployer);
// Deploy implementation contracts.
// TODO: Last 3 addresses are for the follow modules for migration purposes.
hubImpl = new LensHubInitializable({ // TODO: Should we use the usual LensHub, not Initializable?rf
moduleGlobals: address(moduleGlobals),
followNFTImpl: followNFTImplAddr,
collectNFTImpl: legacyCollectNFTImplAddr,
lensHandlesAddress: address(lensHandles),
tokenHandleRegistryAddress: address(tokenHandleRegistry),
legacyFeeFollowModule: address(0), // TODO: Fill this in
legacyProfileFollowModule: address(0), // TODO: Fill this in
newFeeFollowModule: address(0), // TODO: Fill this in
tokenGuardianCooldown: PROFILE_GUARDIAN_COOLDOWN
});
followNFT = new FollowNFT(hubProxyAddr);
legacyCollectNFT = new LegacyCollectNFT(hubProxyAddr);
vm.stopPrank();
// Upgrade the hub.
TransparentUpgradeableProxy oldHubAsProxy = TransparentUpgradeableProxy(payable(hubProxyAddr));
vm.prank(proxyAdmin);
oldHubAsProxy.upgradeTo(address(hubImpl));
}
function deployBaseContracts() internal {
deployer = _loadAddressAs('DEPLOYER');
@@ -210,8 +236,8 @@ contract TestSetup is Test, ForkManagement, ArrayHelpers {
vm.startPrank(deployer);
// Precompute needed addresses.
address followNFTAddr = computeCreateAddress(deployer, vm.getNonce(deployer) + 1);
address legacyCollectNFTAddr = computeCreateAddress(deployer, vm.getNonce(deployer) + 2);
address followNFTImplAddr = computeCreateAddress(deployer, vm.getNonce(deployer) + 1);
address legacyCollectNFTImplAddr = computeCreateAddress(deployer, vm.getNonce(deployer) + 2);
hubProxyAddr = computeCreateAddress(deployer, vm.getNonce(deployer) + 3);
address lensHandlesImplAddr = computeCreateAddress(deployer, vm.getNonce(deployer) + 4);
address lensHandlesProxyAddr = computeCreateAddress(deployer, vm.getNonce(deployer) + 5);
@@ -222,8 +248,8 @@ contract TestSetup is Test, ForkManagement, ArrayHelpers {
// TODO: Last 3 addresses are for the follow modules for migration purposes.
hubImpl = new LensHubInitializable({
moduleGlobals: address(moduleGlobals),
followNFTImpl: followNFTAddr,
collectNFTImpl: legacyCollectNFTAddr,
followNFTImpl: followNFTImplAddr,
collectNFTImpl: legacyCollectNFTImplAddr,
lensHandlesAddress: lensHandlesProxyAddr,
tokenHandleRegistryAddress: tokenHandleRegistryProxyAddr,
legacyFeeFollowModule: address(0),
@@ -292,7 +318,27 @@ contract TestSetup is Test, ForkManagement, ArrayHelpers {
vm.stopPrank();
}
function setUp() public virtual {
function setUp() public virtual override {
super.setUp();
if (bytes(forkEnv).length > 0) {
loadBaseAddresses(forkEnv);
} else {
deployBaseContracts();
}
///////////////////////////////////////// Start governance actions.
vm.startPrank(governance);
if (hub.getState() != Types.ProtocolState.Unpaused) {
hub.setState(Types.ProtocolState.Unpaused);
}
// Whitelist the test contract as a profile creator
hub.whitelistProfileCreator(address(this), true);
vm.stopPrank();
///////////////////////////////////////// End governance actions.
domainSeparator = keccak256(
abi.encode(
Typehash.EIP712_DOMAIN,

6
test/helpers/ForkManagement.sol
View File

@@ -28,12 +28,12 @@ contract ForkManagement is Script {
function keyExists(string memory key) internal returns (bool) {
try vm.parseJsonString(json, key) {
return true;
} catch (bytes memory reason) {
} catch (bytes memory) {
return false;
}
}
constructor() {
function setUp() public virtual {
// TODO: Replace with envOr when it's released
forkEnv = vm.envOr({name: string('TESTING_FORK'), defaultValue: string('')});
forkVersion = vm.envOr({name: string('TESTING_FORK_CURRENT_VERSION'), defaultValue: uint256(0)});
@@ -76,7 +76,7 @@ contract ForkManagement is Script {
console.log('\nTarget environment:', forkEnv);
console.log('Network:', network);
if (block.chainid != chainId) revert('Wrong chainId');
console.log('ChainId:', chainId);
console.log('ChainId:', block.chainid);
}
function getNetwork() internal returns (string memory) {

7
test/migrations/Migrations.t.sol
View File

@@ -80,7 +80,12 @@ contract MigrationsTest is Test, ForkManagement {
modulesGovernance = moduleGlobals.getGovernance();
}
function setUp() public onlyFork {
function setUp() public override {
super.setUp();
// This should be tested only on Fork
if (!fork) return;
loadBaseAddresses(forkEnv);
// Precompute needed addresses.