mirror of
https://github.com/lens-protocol/core.git
synced 2026-04-22 03:02:03 -04:00
misc: Removed old TODO comments and added natspec.
This commit is contained in:
@@ -315,7 +315,6 @@ library MetaTxHelpers {
|
||||
|
||||
/**
|
||||
* @dev Wrapper for ecrecover to reduce code size, used in meta-tx specific functions.
|
||||
* todo: Consider using OZ's implementation for ECDSA recovery.
|
||||
*/
|
||||
function _validateRecoveredAddress(
|
||||
bytes32 digest,
|
||||
|
||||
@@ -4,7 +4,9 @@ pragma solidity 0.8.15;
|
||||
|
||||
import {IEIP1271Implementer} from '../interfaces/IEIP1271Implementer.sol';
|
||||
|
||||
// todo: should receive 65 length bytes and decode manually.
|
||||
/**
|
||||
* @dev This is a mock contract that always returns the wrong value upon being checked with EIP-1271.
|
||||
*/
|
||||
contract BadMockEIP1271Implementer is IEIP1271Implementer {
|
||||
function isValidSignature(bytes32 _hash, bytes memory _signature)
|
||||
external
|
||||
|
||||
@@ -4,7 +4,9 @@ pragma solidity 0.8.15;
|
||||
|
||||
import {IEIP1271Implementer} from '../interfaces/IEIP1271Implementer.sol';
|
||||
|
||||
// todo: should receive 65 length bytes and decode manually.
|
||||
/**
|
||||
* @dev This is a mock contract that validates an EIP1271 signature against its deployer.
|
||||
*/
|
||||
contract MockEIP1271Implementer is IEIP1271Implementer {
|
||||
// bytes4(keccak256("isValidSignature(bytes32,bytes)")
|
||||
bytes4 internal constant MAGIC_VALUE = 0x1626ba7e;
|
||||
|
||||
@@ -41,11 +41,6 @@ import {
|
||||
|
||||
/**
|
||||
* Note: We use the `lensHubImpl` contract to test ERC721 specific events.
|
||||
*
|
||||
* TODO: Add specific test cases to ensure all module encoded return data parameters are
|
||||
* as expected.
|
||||
*
|
||||
* TODO: Add module deployment tests.
|
||||
*/
|
||||
makeSuiteCleanRoom('Events', function () {
|
||||
let receipt: TransactionReceipt;
|
||||
|
||||
Reference in New Issue
Block a user