github/core
1
1
Fork 0
mirror of https://github.com/lens-protocol/core.git synced 2026-04-22 03:02:03 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #123 from lens-protocol/fix/C4-109-L02-passing-zero-to-unlink

Browse Source 
fix: [C4-109-L02] Unlink could be called for any unlinked handles by passing zero
This commit is contained in:
Alan
2023-09-04 18:35:06 +01:00
committed by GitHub
parent 7b65c005c5 154e3e992d
commit b3ea2fa6ad
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
contracts/namespaces/TokenHandleRegistry.sol
View File

@@ -176,6 +176,9 @@ contract TokenHandleRegistry is ITokenHandleRegistry {
}
function _unlink(uint256 handleId, uint256 profileId, address transactionExecutor) private {
if (handleId == 0 || profileId == 0) {
revert RegistryErrors.DoesNotExist();
}
if (
ILensHandles(LENS_HANDLES).exists(handleId) &&
ILensHandles(LENS_HANDLES).ownerOf(handleId) != transactionExecutor &&

6
test/namespaces/TokenHandleRegistryTest.t.sol
View File

@@ -112,16 +112,16 @@ contract TokenHandleRegistryTest is BaseTest {
assertEq(tokenHandleRegistry.resolve(handleId), profileId);
assertEq(tokenHandleRegistry.getDefaultHandle(profileId), handleId);
vm.expectRevert(RegistryErrors.NotLinked.selector);
vm.expectRevert(RegistryErrors.DoesNotExist.selector);
vm.prank(otherAddress);
tokenHandleRegistry.unlink(handleId, 0);
vm.expectRevert(RegistryErrors.NotLinked.selector);
vm.expectRevert(RegistryErrors.DoesNotExist.selector);
vm.prank(otherAddress);
tokenHandleRegistry.unlink(0, profileId);
console.log('0, 0');
vm.expectRevert(RegistryErrors.NotLinked.selector);
vm.expectRevert(RegistryErrors.DoesNotExist.selector);
vm.prank(otherAddress);
tokenHandleRegistry.unlink(0, 0);
}