Commit Graph

267 Commits

Author SHA1 Message Date
Wolphin
ff74358817 run with name 2022-04-05 18:44:45 +03:00
Zer0dot
bc0be7650d Merge pull request #88 from aave/feat/return-ids 2022-04-04 17:55:56 -04:00
Zer0dot
a342572f87 Merge pull request #93 from aave/refactor/return-value-optimizations 2022-04-04 17:18:52 -04:00
Peter Michael
e66acc5476 misc: Added missing "unchecked" blocks. 2022-04-04 17:11:32 -04:00
Peter Michael
9d4edf2870 refactor: Placed unchecked blocks around signature functions and ++ increments, also slightly rearranged follow & collect NFT mint functions to remove one LoC. 2022-04-04 17:07:05 -04:00
donosonaumczuk
afb7bf2a7c Tests added 2022-04-04 18:00:50 +01:00
donosonaumczuk
9ef55d2165 Small gas improvement 2022-04-04 18:00:41 +01:00
Zer0dot
7fd65342c2 Merge pull request #86 from aave/feat/peripheral-profile-metadata 2022-04-04 11:03:35 -04:00
donosonaumczuk
a8aefc137c Natspec improvement + Tiny refactor to avoid passing whole mapping 2022-04-04 11:51:12 +01:00
donosonaumczuk
7cb5d8433f Up to date with main branch - Conflicts solved 2022-04-04 11:02:31 +01:00
Peter Michael
1bb385603c feat: Updated LensPeriphery function names to be more explicit, added tests and moved all LensPeriphery tests to the misc test file. 2022-04-01 18:41:07 -04:00
Peter Michael
6e96132bf1 Merge branch 'main' into feat/peripheral-profile-metadata 2022-04-01 14:32:58 -04:00
Zer0dot
7f82ef1b8e Merge pull request #89 from aave/feat/collect-modules-toggle-follower-only 2022-04-01 14:23:04 -04:00
Peter Michael
c696e1b73d misc: Updated comment. 2022-04-01 14:02:34 -04:00
Peter Michael
707144b70e Merge branch 'main' into feat/collect-modules-toggle-follower-only 2022-04-01 13:42:41 -04:00
Zer0dot
2799970d6d Merge pull request #80 from aave/refactor/general-optimizations 2022-04-01 13:11:02 -04:00
Alan
174df22b5e Merge pull request #85 from aave/feat/follower-only-owner-bypass
Publication owner bypasses FollowValidationModuleBase's follow validation
2022-04-01 15:28:56 +01:00
Peter Michael
03a17e55e3 misc: Rearranged variable ordering. 2022-04-01 10:20:33 -04:00
donosonaumczuk
05706464b6 Tests added about pub owner collecting his own pub without following himself 2022-04-01 14:54:49 +01:00
Peter Michael
a1fb1a6c77 misc: Updated collect module tests to match zero amount checks. 2022-03-31 19:12:21 -04:00
Peter Michael
4a6df79c53 Merge branch 'main' into feat/collect-modules-toggle-follower-only 2022-03-31 19:05:15 -04:00
Peter Michael
3b9f2be9ae feat: Updated modules to return correct data and added tests. Also includes a refactor of the FollowerOnlyCollectModule into the FreeCollectModule with a similar toggle. 2022-03-31 18:54:36 -04:00
donosonaumczuk
84a8b87b7d LensHub now returns IDs for profile creation, collect, mirror, comment and follow 2022-03-31 20:29:57 +01:00
donosonaumczuk
76151b3662 InteractionLogic lib now returns IDs for collect and follow 2022-03-31 20:28:56 +01:00
donosonaumczuk
88d4320b14 FollowNFT now returns token ID 2022-03-31 20:27:39 +01:00
donosonaumczuk
00b0a99ef3 CollectNFT now returns token ID 2022-03-31 20:27:09 +01:00
Peter Michael
7c0ff8520c refactor: Slight gas optimization. 2022-03-31 14:37:45 -04:00
Peter Michael
90d6c69049 refactor: Increment the publication count before comment creation, and manually prevent self-referencing comments. 2022-03-31 12:19:46 -04:00
Zer0dot
507f39e6eb Merge pull request #87 from aave/misc/commented-approval-follow-module-deployment 2022-03-31 11:06:46 -04:00
Alan
ece1f7bb25 Merge pull request #79 from aave/feat/additional-handle-characters
Feat: Allow Hyphens and Underscores in Handles
2022-03-31 14:10:41 +01:00
donosonaumczuk
3eb9802c5b Tests updated to use isFollowing method instead of the old one 2022-03-31 13:06:25 +01:00
donosonaumczuk
58555ba7af FollowValidationModuleBase short circuit improvement using isFollowing 2022-03-31 13:06:04 +01:00
donosonaumczuk
3e033d26ed Follow module base contract isFollowing implementation added 2022-03-31 13:05:29 +01:00
donosonaumczuk
c1befa2fe4 IFollowModule validateFollow replaced with isFollowing that returns boolean instead of reverting 2022-03-31 13:03:38 +01:00
Peter Michael
db603bccfe misc: Commented out approval follow module deployment from tasks. 2022-03-30 17:38:07 -04:00
Peter Michael
98464b568d misc: Renamed EmptyCollectModule to more accurate FollowerOnlyCollectModule. 2022-03-30 17:14:41 -04:00
Peter Michael
835e26a253 misc: Capitalized comments. 2022-03-30 17:05:40 -04:00
Zer0dot
dbe0a8540e Merge pull request #84 from aave/refactor/83-redundant-snapshot-logic 2022-03-30 16:51:19 -04:00
Peter Michael
1e9901de23 misc: Renamed LensPeripheryDataProvider to more accurate shortened LensPeriphery, including the name used in the domain separator. 2022-03-30 16:49:47 -04:00
Peter Michael
dd82346393 misc: Added return types and cleaned up comments. 2022-03-30 14:15:10 -04:00
donosonaumczuk
268055df77 Tests updated to compare SVGs loading expected ones 2022-03-30 17:54:13 +01:00
donosonaumczuk
efc5a811fe Test helpers functions added: load test resources & decode SVG form metadata 2022-03-30 17:53:37 +01:00
donosonaumczuk
86aaa4e53f Test resources added for expected profile tokenURI SVGs 2022-03-30 17:51:28 +01:00
Peter Michael
2c30269f1a misc: Clarified comments for boolean return values. 2022-03-30 10:47:47 -04:00
Peter Michael
ecd851baf5 misc: Removed redundant bracket scopes from single-line "if" statements. 2022-03-30 10:42:10 -04:00
miguelmtzinf
6a95e0ec1f fix: Remove unneeded unchecked blocks 2022-03-30 13:40:03 +02:00
donosonaumczuk
59e28d5f8b Tests added 2022-03-29 17:27:59 +01:00
donosonaumczuk
008e682a99 FollowValidationModuleBase's _checkFollowValidity now bypasses publication owner 2022-03-29 17:27:42 +01:00
Lasse Herskind
4a7c66a113 refactor: Add _getSnapshotValueByBlockNumber helper 2022-03-29 13:35:36 +01:00
donosonaumczuk
b9a5f42942 Small re-arrange to save more gas 2022-03-28 19:17:04 +01:00