github/darkfi
1
1
Fork 0
mirror of https://github.com/darkrenaissance/darkfi.git synced 2026-04-28 03:00:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

store: do not shuffle hosts on fetch_address()

Browse Source 
Previously we were shuffling hosts that we select to avoid trying to
connect to them in a deterministic order. However, this contradicts the
protocol of ordering hostlists by last_seen.

Instead, we should try to connect to addresses stored at the top of the
hostlists first, as they are most likely to be active.

The problem of multiple slots competing for the same peer should be
solved by the various locking checks in check_address_with_lock().
This commit is contained in:
lunar-mining
2024-01-17 15:13:54 +01:00
parent f3361db4c4
commit 2674cfd32e
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/net/hosts/store.rs
View File

@@ -125,10 +125,6 @@ impl Hosts {
hosts.push((addr, last_seen));
}
// Randomize hosts list. Do not try to connect in a deterministic order.
// This is healthier for multiple slots to not compete for the same addrs.
hosts.shuffle(&mut OsRng);
hosts
}
@@ -171,10 +167,6 @@ impl Hosts {
trace!(target: "store::whitelist_fetch_address()",
"Grabbed hosts, length: {}", hosts.len());
// Randomize hosts list. Do not try to connect in a deterministic order.
// This is healthier for multiple slots to not compete for the same addrs.
hosts.shuffle(&mut OsRng);
hosts
}
@@ -217,10 +209,6 @@ impl Hosts {
trace!(target: "store::anchorlist_fetch_address()",
"Grabbed hosts, length: {}", hosts.len());
// Randomize hosts list. Do not try to connect in a deterministic order.
// This is healthier for multiple slots to not compete for the same addrs.
hosts.shuffle(&mut OsRng);
hosts
}