github/darkfi
1
1
Fork 0
mirror of https://github.com/darkrenaissance/darkfi.git synced 2026-04-28 03:00:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

refinery: acquire exclusive lock on greylist before refining

Browse Source 
Modifications to the greylist (appending or deleting from) are dangerous while the refinery is ongoing, since it can lead to panics in the case the refinery fails (because we delete from the greylist by index when that happens).

We mitigate this issue by acquiring an exclusive lock on the greylist before proceeding with the refinery, and dropping the lock once the refinery process has finished and greylist modifications are no longer dangerous.
This commit is contained in:
draoi
2024-04-02 13:44:45 +02:00
parent 564089646d
commit 7ff45ea2a5
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/net/session/refine_session.rs
View File

@@ -250,9 +250,8 @@ impl GreylistRefinery {
}
// Freeze the greylist in this state. Necessary since the greylist
// can be modified by `hosts::move_host()`.
let mut greylist =
hosts.container.hostlists[HostColor::Grey as usize].write().await;
// can be modified by `hosts::move_host()` or `hosts::store()`.
let mut greylist = hosts.container.hostlists[HostColor::Grey as usize].write().await;
if !self.session().handshake_node(url.clone(), self.p2p().clone()).await {
greylist.remove(position);