github/darkfi
1
1
Fork 0
mirror of https://github.com/darkrenaissance/darkfi.git synced 2026-04-28 03:00:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

src/event_graph: aquire locks outside loops

Browse Source
This commit is contained in:
Dastan-glitch
2024-01-13 20:41:17 +03:00
parent befba39321
commit d3be6c2819
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/event_graph/mod.rs
View File

@@ -401,7 +401,6 @@ impl EventGraph {
);
return Err(Error::DagSyncFailed)
}
// }
} // <-- while !missing_parents.is_empty
// At this point we should've got all the events.

15
src/event_graph/proto.rs
View File

@@ -416,8 +416,10 @@ impl ProtocolEventGraph {
// Check if the incoming event is older than the genesis event. If so, something
// has gone wrong. The event should have been pruned during the last
// rotation.
for event in events.clone() {
let genesis_timestamp = self.event_graph.current_genesis.read().await.timestamp;
let genesis_timestamp = self.event_graph.current_genesis.read().await.timestamp;
let mut bcast_ids = self.event_graph.broadcasted_ids.write().await;
for event in events.iter() {
if event.timestamp < genesis_timestamp {
error!(
target: "event_graph::protocol::handle_event_req()",
@@ -429,17 +431,16 @@ impl ProtocolEventGraph {
// Now let's get the upper level of event IDs. When we reply, we could
// get requests for those IDs as well.
let mut bcast_ids = self.event_graph.broadcasted_ids.write().await;
for parent_id in event.parents.iter() {
if parent_id != &NULL_ID {
bcast_ids.insert(*parent_id);
}
}
// TODO: We should remove the reply from the bcast IDs for this specific channel.
// We can't remove them for everyone.
//bcast_ids.remove(&event_id);
drop(bcast_ids);
}
// TODO: We should remove the reply from the bcast IDs for this specific channel.
// We can't remove them for everyone.
//bcast_ids.remove(&event_id);
drop(bcast_ids);
// Reply with the event
self.channel.send(&EventRep(events)).await?;