Drew Ulmer
00e8841e93
Unit test for Lockable#unauthenticated_message not leaking account existence
...
This is another failing test for #1994 , a unit test for Lockable. Lockable's
#uanauthenticated_message should not return :locked if paranoid mode is on
and instead should return the generic :invalid response.
2012-10-25 16:51:02 -05:00
Drew Ulmer
f79bb31ee6
Add failing test for Issue #1994
...
Lockable should not leak information about account existence if paranoid
mode is on.
2012-10-25 16:20:21 -05:00
Jason Rush
b27491061e
Test helper was incorrectly returning failure body
...
The _process_unauthenticated method in test_helper was returning
the response as the body. When setting rendering the text, it was
calling to_s on the response which would render something like
this: #<ActionDispatch::Response:0x007fb9e1efea00>. This change
renders the body of the response instead of the response itself
2012-09-27 18:44:31 -06:00
José Valim
4a24667e80
Revert "Rails 3.2.7 deprecates update_attribute in favor of update_column"
...
Rails 3.2.8 is rolling back the deprecations.
This reverts commit 7d41072c0e .
2012-08-05 09:24:10 -03:00
Fabio Kreusch
7d41072c0e
Rails 3.2.7 deprecates update_attribute in favor of update_column. Updated projects using Devise output lots of warnings because Devise uses the deprecated version in some places. This commit replaces update_attribute with update_column to fix that.
2012-07-27 17:25:21 -03:00
José Valim
bdf0bc7b1e
Revert "Revert "New password default minimum length is now 8""
...
This reverts commit b1f490a2f8 .
Actually, the implementation was good!
2012-07-24 23:41:17 +02:00
José Valim
b1f490a2f8
Revert "New password default minimum length is now 8"
...
This reverts commit 2950434ed3 .
It is backwards incompatible, we need a better migration plan.
2012-07-24 22:41:13 +02:00
Víctor Manuel Cruz Dueñas
73f617db7b
Checking if unconfirmed_email has changed before to set update_needs_confirmation flash message.
...
Conflicts:
test/integration/registerable_test.rb
Signed-off-by: José Valim <jose.valim@plataformatec.com.br >
2012-07-23 16:20:51 +02:00
José Valim
6e79c5c242
Ensure a new token is generated if the previous one expired
2012-07-23 16:05:51 +02:00
Nils Landt
dcada8fe75
Refactor according to line notes from josevalim
...
- rename reset_password_within to confirm_within
- confirmation_period_valid? is back and memoized
- fix hash syntax to hashrocket
2012-07-22 14:02:27 +02:00
Nils Landt
f80cecc864
Remove unnecessary include
2012-07-16 11:50:46 +02:00
Nils Landt
1d6ee13aae
Refactor according to rodrigoflores
...
- Favor using update_attribute instead of constructor parameters in user
factory for tests
- Test for accurate error message when confirmation token is expired
- Don't check twice whether the confirmation period is expired
2012-07-16 11:20:01 +02:00
Nils Landt
6e48fcee76
Fix tests for email token expiration
...
The tests work now, but are a bit wonky because User.create does things
I don't understand.
2012-07-11 18:30:36 +02:00
Nils Landt
42a0c30139
Refactored according to line notes by rodrigoflores
2012-07-11 15:49:41 +02:00
Nils Landt
87f2fa9767
Add options to expire confirmation tokens
...
With this patch, functionality is added to expire the confirmation
tokens that are being sent by email.
For example, if a token is valid for 3 days only, it cannot be used for
confirmation on the 4th day.
2012-07-09 14:43:12 +02:00
Rodrigo Flores
2950434ed3
New password default minimum length is now 8
2012-07-06 13:41:28 -03:00
Carlos Galdino
c179cef365
Change the minimum password length to 8
2012-07-06 11:46:46 -03:00
José Valim
cbc6926e3d
Fix issue #1928 , thanks to @ejfinneran for a test case
2012-06-28 12:05:20 +02:00
José Valim
9678b422ff
Merge pull request #1954 from mrchrisadams/d1bf31729d10fbb65f1b7ce158f3926aa946b3ad
...
Allow setting of default reply_to fields on mailer mails - #1936
2012-06-27 03:19:52 -07:00
Chris Adams
d1bf31729d
Address issue #1936
...
Update mailer to accept reply_to as a default param as well, as discussed in
https://github.com/plataformatec/devise/issues/1936#issuecomment-6583637
2012-06-26 23:11:35 +01:00
dblock
619826fbc8
Test that confirms that #1948 is not an issue.
2012-06-25 18:33:48 -04:00
mathieul
95f20587ef
test that destroying a session doesn't set the flash if the requested format is not navigational
2012-06-23 14:43:35 -07:00
Carlos Antonio da Silva
0c9b79947d
Fix locked_at column in lockable required fields logic
...
See a7658f9d75 (commitcomment-1493199)
Thanks @nickhoffman
2012-06-22 22:31:57 -03:00
José Valim
4f07ed42e3
Lock warden on sign out
2012-06-16 15:21:48 +02:00
José Valim
4bc2ff997a
Timeout does not explode when reset_authentication_token! is accidentally defined by Active Model
2012-06-16 14:04:34 +02:00
José Valim
b1633f2454
Delegate omniauth_authorize_path to the router, closes #1843
2012-06-16 13:43:11 +02:00
José Valim
41a91188f5
Do not trigger timeout on sign in related actions
2012-06-16 13:24:07 +02:00
Chris Oliver
37c55eb192
Added tests for flexible routing constraints
2012-06-15 13:06:29 -05:00
José Valim
c4818a9fb2
Reorganize tests slightly
2012-06-15 11:15:03 +02:00
Gregory Bataille
ff75341c75
Redirect to sign in page when trying to access password#edit without a
...
reset_password_token (i.e. not coming from a reset password email)
2012-06-08 10:08:35 +02:00
Shaliko Usubov
db8eeb6c6e
Remove not used variables
2012-05-26 20:31:42 +04:00
José Valim
2b7328535d
Check for the request before checking for the mapping, closes #1859
2012-05-25 09:39:50 +02:00
Carlos Antonio da Silva
b6e30427a3
Pass the block argument straight to the assertion methods in test helpers
2012-05-15 17:19:21 -03:00
Carlos Antonio da Silva
96e0dcf5d5
Remove not used variable, fix indent
2012-05-15 17:14:05 -03:00
Adam Meehan
7ec4c1424d
Add resource_params internal helper to param filtering
...
In light of recent discussions around mass assignment security and
the alternate solution of using the controller to filter params, not the model,
a hook/helper is needed to be able to override how the params are filtered
before they are used to build the resource.
2012-05-15 18:07:02 +10:00
Rodrigo Flores
8baacecdcf
Fixing tests
2012-05-14 17:53:34 -03:00
José Valim
454a5ad1ec
Try to fix the build for rails 3.1
2012-05-09 23:41:05 +02:00
Rodrigo Flores
1698f0f57c
Merge branch 'removing_encryptable'
2012-05-09 18:05:14 -03:00
Rodrigo Flores
39dc9a7ba6
Removed encryptable references on rails_app
2012-05-09 14:49:55 -03:00
José Valim
65ef2592f6
Add a test case to previous commit
2012-05-09 18:27:44 +02:00
Rodrigo Flores
768f8832b9
Removing encryptable module
2012-05-07 16:37:16 -03:00
José Valim
32f20dddd6
Get rid of deprecated code
2012-05-06 13:13:53 +02:00
José Valim
5e845ee265
Do not reproduce warden behavior, simply rely on the controller calling it
2012-05-06 12:09:53 +02:00
Matt Connolly
a9b7a4a1de
Reinstating tests for the controller test's response object. This does need to be set so the strategy's custom response can be tested.
2012-05-06 19:24:57 +10:00
Matt Connolly
2a3a8b8008
Changing test to not bother with saved response, since it wasn't set by the test.
2012-05-06 17:08:00 +10:00
Matt Connolly
90a63d4d89
Completing test and functionality for TestHelper to correctly return a custom response from a warden strategy.
2012-05-06 16:48:39 +10:00
Matt Connolly
66f74ed579
Adding a test for a warden strategy retuning a custom response.
2012-05-06 13:35:24 +10:00
José Valim
d376d11d42
Merge pull request #1825 from julianvargasalvarez/master
...
Use 'head :no_content' in sessions_controller#destroy
2012-05-03 00:27:21 -07:00
Julian Vargas
6664acd27f
Use 'head :no_content' in sessions_controller#destroy
...
Code cleanup for returning headers instead of an empty string
when destroying sessions.
Lines 464 and 471 on test/integration/autenticatable_test.rb
were adjusted to assert on :no_content
2012-05-02 22:40:53 -05:00
Rodrigo Flores
525bcd4e2d
Refactoring simulation inside engine to decide based on the api
2012-05-02 14:53:14 -03:00