github/devise
1
1
Fork 0
mirror of https://github.com/heartcombo/devise.git synced 2026-01-23 13:48:06 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,048 Commits 28 Branches 146 Tags
v2.2.2
Commit Graph

786 Commits

Author SHA1 Message Date
Vasiliy Ermolovich
9913fde749 use click_button for canceling account in integration specs 2013-01-12 14:12:05 +03:00
José Valim
33fb89340a Revert "update_with_password doesn't change encrypted password when it is invalid" 
This reverts commit 10235f9d72.
 2013-01-11 19:12:53 +01:00
Drew Ulmer
c768366240 Add failing tests for Issue #2204 
For a point release upgrade, Devise should not throw an exception when trying
to downcase or strip globally configured keys. This would be a breaking
change in functionality and this test demonstrates the issue.
 2013-01-09 11:41:20 -06:00
Alan Larkin
84b8188db9 Added failing integration test for XHR invocation of SessionsController#destroy with */*' in the Accept' header. 2013-01-06 03:49:59 +00:00
José Valim
30ab6f923d Release 2.2.0.rc 2012-12-13 09:20:46 +01:00
José Valim
839e8fc8ac Show if there is an e-mail waiting for confirmation, closes #2060 2012-12-13 09:13:33 +01:00
José Valim
4c83743263 unconfirmed_email now uses the proper e-mail on salutation, related to #2060 2012-12-13 09:02:59 +01:00
José Valim
e1fde192f2 Update CHANGELOG 2012-12-13 08:43:43 +01:00
Carlos Antonio da Silva
ac3a25bf2e Remove nothing raised assertion 
Let the test raise if that is the case, no need for assert that nothing
was raised.

Hopefully fix the build ✨
 2012-12-04 17:49:26 -02:00
Carlos Antonio da Silva
2261005ed5 Refactor a bit to avoid two model attributes lookup 
Tidy up tests a bit.
 2012-12-04 17:37:12 -02:00
Drew Ulmer
0c6f2adf14 Add failing test for #2129 2012-12-01 21:06:11 -06:00
Drew Ulmer
77ec1b08cd Move test models into their own file so they can be used elsewhere 2012-12-01 21:06:03 -06:00
José Valim
3696cbf33e Merge pull request #2148 from kukula/master 
Fix default email_regexp config to not allow spaces
 2012-11-21 02:58:30 -08:00
Gabe Martin-Dempesy
130d684198 Change failure key for missing database resource to :invalid_email 2012-11-19 15:49:21 -08:00
Anatoliy Kukul
f0f3e15c08 add test for Devise.email_regexp 2012-11-19 17:38:22 +02:00
Jared Morgan
f044916f94 Use correct current_password in RegistrationTest of invalid confirmation 
In DatabaseAuthenticatable#update_with_password, password is now deleted if
the current_password is invalid. dm-validations will not check the
confirmation in that case, so this test was failing in dm-devise.
 2012-11-15 12:21:11 -06:00
Durran Jordan
d821275588 Fix spec failures for Mongoid 3. 
This has no actual changes to Devise itself, just fixes the failing
tests when running against Mongoid 3 instead of Mongoid 2.

Mocha has been locked at 0.10.0 since 0.12.0 raises an error when trying
to set an expectation on a frozen object.

Tests were updated to work with both AR and Mongoid, some cases the XML
serialization was slightly different but both were outputting correct
and valid XML, and the id/_id field mismatch is now handled.

An active field was missing from the test models for Mongoid, and the
invalid :null => true options in field were removed.
 2012-11-10 20:02:58 +01:00
José Valim
b1df686a2e Merge pull request #2137 from nashby/indifferent 
remove useless test
 2012-11-08 11:25:08 -08:00
Vasiliy Ermolovich
ae426dcc1c remove useless test 2012-11-08 22:22:03 +03:00
José Valim
1646684af9 Merge pull request #2134 from marcinb/master 
unlock user after password re-set
 2012-11-07 14:15:00 -08:00
Marcin Balinski
ac58c28617 Unlock user when re-setting password and unlock strategy is :email or :both 2012-11-07 10:45:46 +01:00
Vasiliy Ermolovich
10235f9d72 update_with_password doesn't change encrypted password when it is invalid 
closes #2130
 2012-11-06 21:05:17 +03:00
Vasiliy Ermolovich
61903b534a don't delete the return to url from session if the requested format is not navigational 
closes #2122
 2012-11-04 23:42:38 +03:00
José Valim
06a2cff140 Merge pull request #2117 from nashby/fix-issue-2043 
handle namespaced models in AR generator
 2012-10-27 15:25:32 -07:00
Vasiliy Ermolovich
2f36d0dd32 handle namespaced models in AR generator 
closes #2043
 2012-10-28 00:59:33 +03:00
José Valim
8ee1591868 Merge pull request #2115 from latortuga/1994-paranoid-locking 
Add failing test for Issue #1994
 2012-10-26 02:22:49 -07:00
José Valim
18c377e0d7 Merge pull request #2112 from latortuga/patch-1 
Make #set_flash_message respect i18n-set resource_name
 2012-10-26 02:05:42 -07:00
Drew Ulmer
00e8841e93 Unit test for Lockable#unauthenticated_message not leaking account existence 
This is another failing test for #1994, a unit test for Lockable. Lockable's
#uanauthenticated_message should not return :locked if paranoid mode is on
and instead should return the generic :invalid response.
 2012-10-25 16:51:02 -05:00
Drew Ulmer
f79bb31ee6 Add failing test for Issue #1994 
Lockable should not leak information about account existence if paranoid
mode is on.
 2012-10-25 16:20:21 -05:00
Drew Ulmer
d6449d014e Add test for #devise_i18n_options allowing resource_name override 2012-10-24 12:13:07 -05:00
Jason Rush
b27491061e Test helper was incorrectly returning failure body 
The _process_unauthenticated method in test_helper was returning
the response as the body. When setting rendering the text, it was
calling to_s on the response which would render something like
this: #<ActionDispatch::Response:0x007fb9e1efea00>. This change
renders the body of the response instead of the response itself
 2012-09-27 18:44:31 -06:00
José Valim
4a24667e80 Revert "Rails 3.2.7 deprecates update_attribute in favor of update_column" 
Rails 3.2.8 is rolling back the deprecations.

This reverts commit 7d41072c0e.
 2012-08-05 09:24:10 -03:00
Fabio Kreusch
7d41072c0e Rails 3.2.7 deprecates update_attribute in favor of update_column. Updated projects using Devise output lots of warnings because Devise uses the deprecated version in some places. This commit replaces update_attribute with update_column to fix that. 2012-07-27 17:25:21 -03:00
José Valim
bdf0bc7b1e Revert "Revert "New password default minimum length is now 8"" 
This reverts commit b1f490a2f8.
Actually, the implementation was good!
 2012-07-24 23:41:17 +02:00
José Valim
b1f490a2f8 Revert "New password default minimum length is now 8" 
This reverts commit 2950434ed3.
It is backwards incompatible, we need a better migration plan.
 2012-07-24 22:41:13 +02:00
Víctor Manuel Cruz Dueñas
73f617db7b Checking if unconfirmed_email has changed before to set update_needs_confirmation flash message. 
Conflicts:

	test/integration/registerable_test.rb

Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
 2012-07-23 16:20:51 +02:00
José Valim
6e79c5c242 Ensure a new token is generated if the previous one expired 2012-07-23 16:05:51 +02:00
Nils Landt
dcada8fe75 Refactor according to line notes from josevalim 
- rename reset_password_within to confirm_within
- confirmation_period_valid? is back and memoized
- fix hash syntax to hashrocket
 2012-07-22 14:02:27 +02:00
Nils Landt
f80cecc864 Remove unnecessary include 2012-07-16 11:50:46 +02:00
Nils Landt
1d6ee13aae Refactor according to rodrigoflores 
- Favor using update_attribute instead of constructor parameters in user
  factory for tests
- Test for accurate error message when confirmation token is expired
- Don't check twice whether the confirmation period is expired
 2012-07-16 11:20:01 +02:00
Nils Landt
6e48fcee76 Fix tests for email token expiration 
The tests work now, but are a bit wonky because User.create does things
I don't understand.
 2012-07-11 18:30:36 +02:00
Nils Landt
42a0c30139 Refactored according to line notes by rodrigoflores 2012-07-11 15:49:41 +02:00
Nils Landt
87f2fa9767 Add options to expire confirmation tokens 
With this patch, functionality is added to expire the confirmation
tokens that are being sent by email.
For example, if a token is valid for 3 days only, it cannot be used for
confirmation on the 4th day.
 2012-07-09 14:43:12 +02:00
Rodrigo Flores
2950434ed3 New password default minimum length is now 8 2012-07-06 13:41:28 -03:00
Carlos Galdino
c179cef365 Change the minimum password length to 8 2012-07-06 11:46:46 -03:00
José Valim
cbc6926e3d Fix issue #1928, thanks to @ejfinneran for a test case 2012-06-28 12:05:20 +02:00
José Valim
9678b422ff Merge pull request #1954 from mrchrisadams/d1bf31729d10fbb65f1b7ce158f3926aa946b3ad 
Allow setting of default reply_to fields on mailer mails - #1936
 2012-06-27 03:19:52 -07:00
Chris Adams
d1bf31729d Address issue #1936 
Update mailer to accept reply_to as a default param as well, as discussed in 

https://github.com/plataformatec/devise/issues/1936#issuecomment-6583637
 2012-06-26 23:11:35 +01:00
dblock
619826fbc8 Test that confirms that #1948 is not an issue. 2012-06-25 18:33:48 -04:00
mathieul
95f20587ef test that destroying a session doesn't set the flash if the requested format is not navigational 2012-06-23 14:43:35 -07:00