3070 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
José Valim	1516a0ae6d	Release v3.5.4 v3.5.4	2016-01-18 15:12:07 +01:00
José Valim	c92996646a	Store creation timestamp on remember cookies ... Signed-off-by: José Valim <jose.valim@plataformatec.com.br>	2016-01-18 14:47:31 +01:00
Kacper Walanus	ba5dd0a41a	test for save in after_create hook breaks devise confirmation [3787]	2015-12-15 11:41:48 -02:00
Christian Macias	f63be5039a	changed email_was !='' to email_was.present?	2015-12-15 11:41:33 -02:00
Christian Macias	f25562fd4b	fix for #3787, save in after_create hook breaks devise confirmation	2015-12-15 11:41:33 -02:00
Siva Gollapalli	2a2fd806a8	FIX# Comparing times in UTC	2015-12-15 11:40:59 -02:00
Lucas Mazza	032eb145df	Release 3.5.3. v3.5.3	2015-12-10 14:36:34 -02:00
José Valim	0d941b7ba5	Merge pull request #3847 from stanhu/reset-token-only-on-update ... Only clear the reset token on an update	2015-12-09 20:28:06 +01:00
Stan Hu	f71d843f93	Only clear the reset token on an update ... This solves the issue where a package might do: ``` user = User.new user.email = 'test@test.com' token = user.generate_reset_token user.save send_reset_email(token) ``` Since the save clears the reset token, the user will receive a stale token that no longer works. Closes #3774	2015-12-09 11:14:50 -08:00
Lucas Mazza	7d825c93b6	Update CHANGELOG [ci skip].	2015-12-09 13:53:29 -02:00
José Valim	19b1e2a6bc	Merge pull request #3846 from seddy/make_email_optional_on_recoverable ... Allow resources with no email field to be recoverable	2015-12-09 14:39:32 +01:00
José Valim	901919f25f	Revert "Merge pull request #3774 from stanhu/reset-token-only-if-not-persisted" ... This reverts commit 15c38d918f, reversing changes made to 508c3418f9.	2015-12-09 14:21:09 +01:00
Lucas Mazza	15c38d918f	Merge pull request #3774 from stanhu/reset-token-only-if-not-persisted ... Only clear the reset password token if the model has already been persisted	2015-12-09 10:54:36 -02:00
Lucas Mazza	508c3418f9	Merge pull request #3826 from andygeers/master ... Don't error if resource doesn't need confirming	2015-12-09 10:52:35 -02:00
Ed Saunders	d98e98fe77	Add a test for when a recoverable resource has a non-AR email field	2015-12-08 16:01:39 +00:00
Ed Saunders	4a45eb9899	Allow resources with no email field to be recoverable ... The current implementation is opinionated about the resource should have an "email" column on it if it is to be recoverable, which isn't necessarily the case. For example, developers may decide to pull emails out into their own model or have some other way of communicating password resets to their users (e.g. text message) I'm not sure there's an easy test to put together for this case, as minitest doesn't make it very easy to stub the "email_changed?" to raise an error. Happy to look into building another model in the "test/rails_app" if you want to have this properly tested though? Or for a nice way to get calls to "email_changed?" to raise; minitest isn't a test framework I'm overly familiar with :). As a side note, it would be nice if the Validatable module also took this into account, I may raise another PR for that. This comes off the back of comments on this commit: e641b4b7b9	2015-12-07 17:01:31 +00:00
José Valim	45fc964470	Merge pull request #3739 from stanhu/support-relative-urls-in-failure-app ... Account for relative_url_root in FailureApp's recall method	2015-11-25 20:03:28 +01:00
Stan Hu	56fed052f8	Wrap logic for resetting token into instance method and add comments	2015-11-24 23:23:34 -08:00
Andy Geers	d3f521925e	Write unit test for bug fix	2015-11-18 22:21:03 +00:00
Andy Geers	8a8887ea82	Don't error if resource doesn't need confirming	2015-11-18 22:21:03 +00:00
José Valim	d22ac4a4fb	Merge pull request #3813 from jlerpscher/set-minimum-password-length-on-failure ... set minimum password length on reset failure	2015-11-10 09:37:59 -02:00
Julien Lerpscher	8426b12550	set minimum password length on reset failure	2015-11-10 12:17:29 +01:00
José Valim	57bf362b55	Merge pull request #3808 from blase/skip-timeoutable ... Allow skipping the timeoutable hook	2015-11-04 18:15:03 -02:00
José Valim	18a8260535	Merge pull request #3805 from robuye/master ... Remove outdated example from documentation	2015-11-04 00:48:35 -02:00
Błażej Pankowiak	9f32f421a5	Allow skipping the timeoutable hook	2015-11-02 23:53:09 +01:00
robuye	df6a83b27b	Remove outdated example from documentation ... `#reset_password` always saves the record if validation passes.	2015-11-02 23:06:38 +01:00
Lucas Mazza	4477bab1aa	Update Travis CI notification settings.	2015-11-01 19:54:58 -02:00
José Valim	d6dc93ca3d	Merge pull request #3792 from excid3/master ... Automatically underscore and pluralize scoped views generator	2015-10-22 00:42:40 +02:00
Chris Oliver	005d514adf	Automatically underscore and pluralize scoped views generator. Fixes #3790	2015-10-21 14:53:03 -04:00
Lucas Mazza	9568e28d66	Merge pull request #3783 from yui-knk/doc_singular_option ... [ci skip] Write how to use `singular` option of `ActionDispatch::Rout…	2015-10-19 09:15:34 -04:00
yui-knk	4f2571a408	[ci skip] Write how to use singular option of ActionDispatch::Routing::Mapper#devise_for ... * Replace "the instance variable name in controller" with "the helper methods names in controller". Devise dose not define instance variable for controllers but define helper methods for controllers. * Replace "the name in routes" with "the scope name in routes". `singular` is used as an argument of `devise_scope`. * Add sample codes of routing and controller.	2015-10-16 11:57:42 +09:00
Rafael Mendonça França	e33d285e4a	Update the documentation to use current Rails code [ci skip]	2015-10-15 16:13:06 -03:00
Stan Hu	619128cb9b	Only clear the reset password token if the model has already been persisted ... If a new user is created with a reset password token, the previous behavior would automatically clear the token even when it was desired for setting the password for the first time.	2015-10-02 12:30:57 -07:00
George Guimarães	9f37b6eff7	Merge pull request #3769 from xymbol/fix_typos ... Fix typos	2015-09-30 19:39:49 -03:00
Adrian Mugnolo	2380612b6e	Fix typo: authenticatable	2015-09-30 19:32:44 -03:00
Adrian Mugnolo	c334179c95	Fix typo: successful	2015-09-30 19:31:49 -03:00
José Valim	827d009b3c	Merge pull request #3766 from nambrot/patch-1 ... Add missing comma	2015-09-28 17:28:41 +02:00
Nam Chu Hoai	56edeec958	Add missing comma	2015-09-28 11:25:03 -04:00
Lucas Mazza	7df57d5081	Merge pull request #3732 from posgarou/refactor/respond_to_helper_method ... Wrap helper_method calls in respond_to?(:helper_method)	2015-09-26 11:05:30 -03:00
George Guimarães	2ccffc80b0	Merge pull request #3743 from plataformatec/fdf-add-code-of-conduct ... Add a Code of Conduct	2015-09-08 00:02:47 -03:00
Flavia Fortes	797a19352c	Add a Code of Conduct	2015-09-07 23:59:51 -03:00
Stan Hu	7025f968c6	Account for relative_url_root in FailureApp's recall method ... Closes #3738	2015-09-06 00:05:19 -07:00
Ryan Mitchell	04e01f49a9	Use builtin matchers in helper tests	2015-08-31 09:58:25 -04:00
Ryan Mitchell	a3da40a701	Wrap helper_method calls in respond_to?(:helper_method)	2015-08-29 05:29:05 -04:00
Lucas Mazza	40258bf100	Remove the custom OmniAuth camelization on teardown.	2015-08-28 11:26:41 -03:00
Lucas Mazza	d3baff221d	Merge pull request #3730 from timoschilling/omin-auth-camelization ... use OmniAuth::Utils.camelize	2015-08-28 10:57:20 -03:00
Timo Schilling	f5e984c151	use OmniAuth::Utils.camelize ... This will display the provider name with the original camelization: facebook => Facebook github => GitHub linkedin => LinkedIn	2015-08-28 07:51:37 +02:00
Lucas Mazza	6ed6e09bf3	Merge pull request #3642 from jphenow/add-password-change-notification ... Add password change notification	2015-08-27 12:48:14 -03:00
Jon Phenow	05ccdfbacd	Merge branch 'add-password-change-notification' of github.com:jphenow/devise into add-password-change-notification	2015-08-27 10:43:51 -05:00
Jon Phenow	9bcc2d1c5f	CHANGELOG	2015-08-27 10:26:42 -05:00