github/directus
1
1
Fork 0
mirror of https://github.com/directus/directus.git synced 2026-04-25 03:00:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add perm check for sqlite, upload, extensions dirs (#7310)

Browse Source 
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
This commit is contained in:
Pascal Jufer
2021-08-10 15:39:47 +02:00
committed by GitHub
parent cacd4f4ff1
commit 123c3b1182
2 changed files with 34 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
api/src/app.ts
View File

@@ -41,6 +41,7 @@ import sanitizeQuery from './middleware/sanitize-query';
import schema from './middleware/schema';
import { track } from './utils/track';
import { validateEnv } from './utils/validate-env';
import { validateStorage } from './utils/validate-storage';
import { register as registerWebhooks } from './webhooks';
import { session } from './middleware/session';
import { flushCaches } from './cache';
@@ -54,6 +55,8 @@ export default async function createApp(): Promise<express.Application> {
logger.warn('PUBLIC_URL is not a valid URL');
}
await validateStorage();
await validateDBConnection();
if ((await isInstalled()) === false) {

31
api/src/utils/validate-storage.ts Normal file
View File

@@ -0,0 +1,31 @@
import env from '../env';
import logger from '../logger';
import { access } from 'fs/promises';
import { constants } from 'fs';
import path from 'path';
export async function validateStorage(): Promise<void> {
if (env.DB_CLIENT === 'sqlite3') {
try {
await access(path.dirname(env.DB_FILENAME), constants.R_OK | constants.W_OK);
} catch {
logger.warn(
`Directory for SQLite database file (${path.resolve(path.dirname(env.DB_FILENAME))}) is not read/writeable!`
);
}
}
if (env.STORAGE_LOCATIONS.split(',').includes('local')) {
try {
await access(env.STORAGE_LOCAL_ROOT, constants.R_OK | constants.W_OK);
} catch {
logger.warn(`Upload directory (${path.resolve(env.STORAGE_LOCAL_ROOT)}) is not read/writeable!`);
}
}
try {
await access(env.EXTENSIONS_PATH, constants.R_OK);
} catch {
logger.warn(`Extensions directory (${path.resolve(env.EXTENSIONS_PATH)}) is not readable!`);
}
}