github/directus
1
1
Fork 0
mirror of https://github.com/directus/directus.git synced 2026-04-25 03:00:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

Check for schema identity before updating it. (#5608)

Browse Source
This commit is contained in:
Oreille
2021-05-11 20:36:33 +02:00
committed by GitHub
parent bc30ee2bde
commit 316ac9076b
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
api/src/services/fields.ts
View File

@@ -16,6 +16,7 @@ import { Field } from '../types/field';
import getDefaultValue from '../utils/get-default-value';
import getLocalType from '../utils/get-local-type';
import { toArray } from '../utils/to-array';
import { isEqual } from 'lodash';
export type RawField = DeepPartial<Field> & { field: string; type: typeof types[number] };
@@ -255,13 +256,15 @@ export class FieldsService {
if (field.schema) {
const existingColumn = await this.schemaInspector.columnInfo(collection, field.field);
try {
await this.knex.schema.alterTable(collection, (table) => {
if (!field.schema) return;
this.addColumnToTable(table, field, existingColumn);
});
} catch (err) {
throw await translateDatabaseError(err);
if (!isEqual(existingColumn, field.schema)) {
try {
await this.knex.schema.alterTable(collection, (table) => {
if (!field.schema) return;
this.addColumnToTable(table, field, existingColumn);
});
} catch (err) {
throw await translateDatabaseError(err);
}
}
}