github/directus
1
1
Fork 0
mirror of https://github.com/directus/directus.git synced 2026-04-25 03:00:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

Warn on usage of __ prefixed fields in GraphQL (#4033)

Browse Source 
Fixes #3825
This commit is contained in:
Rijk van Zanten
2021-02-12 15:36:11 -05:00
committed by GitHub
parent ee3f5cbad3
commit 62f040b5d8
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
api/src/services/graphql.ts
View File

@@ -23,6 +23,7 @@ import {
ObjectValueNode,
GraphQLUnionType,
} from 'graphql';
import logger from '../logger';
import { getGraphQLType } from '../utils/get-graphql-type';
import { RelationsService } from './relations';
import { ItemsService } from './items';
@@ -106,6 +107,13 @@ export class GraphQLService {
const fieldsInCollection = fields.filter((field) => field.collection === collection.collection);
for (const field of fieldsInCollection) {
if (field.field.startsWith('__')) {
logger.warn(
`GraphQL doesn't allow fields starting with "__". Field "${field.field}" in collection "${field.collection}" is unavailable in the GraphQL endpoint.`
);
continue;
}
const relationForField = relations.find((relation) => {
return (
(relation.many_collection === collection.collection && relation.many_field === field.field) ||
@@ -297,6 +305,8 @@ export class GraphQLService {
const fieldsInCollection = fields.filter((field) => field.collection === collection.collection);
for (const field of fieldsInCollection) {
if (field.field.startsWith('__')) continue;
const relationForField = relations.find((relation) => {
return (
(relation.many_collection === collection.collection && relation.many_field === field.field) ||