github/ed25519-dalek
1
1
Fork 0
mirror of https://github.com/dalek-cryptography/ed25519-dalek.git synced 2026-01-10 11:37:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

Impl Drop/ZeroizeOnDrop for SigningKey (#247)

Browse Source 
- Zeros out `SigningKey::secret_key` on drop
- Adds the `ZeroizeOnDrop` marker trait to `SigningKey`
This commit is contained in:
Tony Arcieri
2022-12-20 02:28:20 -07:00
committed by GitHub
parent 194b17f18a
commit a0384be8fc
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Cargo.toml
View File

@@ -32,7 +32,7 @@ rand_core = { version = "0.6", default-features = false, optional = true }
serde_crate = { package = "serde", version = "1.0", default-features = false, optional = true }
serde_bytes = { version = "0.11", optional = true }
sha2 = { version = "0.10", default-features = false }
zeroize = { version = "1", default-features = false }
zeroize = { version = "1.5", default-features = false }
[dev-dependencies]
hex = "^0.4"

10
src/signing.rs
View File

@@ -32,7 +32,7 @@ use curve25519_dalek::scalar::Scalar;
use ed25519::signature::{KeypairRef, Signer, Verifier};
use zeroize::Zeroize;
use zeroize::{Zeroize, ZeroizeOnDrop};
use crate::constants::*;
use crate::errors::*;
@@ -512,6 +512,14 @@ impl TryFrom<&[u8]> for SigningKey {
}
}
impl Drop for SigningKey {
fn drop(&mut self) {
self.secret_key.zeroize();
}
}
impl ZeroizeOnDrop for SigningKey {}
#[cfg(feature = "pkcs8")]
impl DecodePrivateKey for SigningKey {}