github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

3665762: Remove RenderFrameHost::IsRenderFrameCreated from //content/.

Browse Source 
https://chromium-review.googlesource.com/c/chromium/src/+/3665762
This commit is contained in:
Shelley Vohr
2022-06-01 11:34:07 +02:00
parent 18aac8e93e
commit 070ea1700b
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/api/electron_api_web_contents.cc
View File

@@ -3487,7 +3487,7 @@ v8::Local<v8::Promise> WebContents::TakeHeapSnapshot(
return handle;
}
if (!frame_host->IsRenderFrameCreated()) {
if (!frame_host->IsRenderFrameLive()) {
promise.RejectWithErrorMessage("takeHeapSnapshot failed");
return handle;
}

2
shell/browser/api/electron_api_web_frame_main.cc
View File

@@ -206,7 +206,7 @@ void WebFrameMain::MaybeSetupMojoConnection() {
// Wait for RenderFrame to be created in renderer before accessing remote.
if (pending_receiver_ && render_frame_ &&
render_frame_->IsRenderFrameCreated()) {
render_frame_->IsRenderFrameLive()) {
render_frame_->GetRemoteInterfaces()->GetInterface(
std::move(pending_receiver_));
}

2
shell/browser/electron_autofill_driver_factory.cc
View File

@@ -80,7 +80,7 @@ AutofillDriver* AutofillDriverFactory::DriverForFrame(
// 3. `SomeOtherWebContentsObserver::RenderFrameDeleted(render_frame_host)`
// calls `DriverForFrame(render_frame_host)`.
// 5. `render_frame_host->~RenderFrameHostImpl()` finishes.
if (render_frame_host->IsRenderFrameCreated()) {
if (render_frame_host->IsRenderFrameLive()) {
driver = std::make_unique<AutofillDriver>(render_frame_host);
DCHECK_EQ(driver_map_.find(render_frame_host)->second.get(),
driver.get());