github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-10 16:08:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

feat: split openExternal into sync and async (#16176)

Browse Source 
* feat: split openExternal into sync and async

* v8::Locker => mate::Locker

* fix: enter js env when resolving promise
This commit is contained in:
Shelley Vohr
2019-01-14 20:35:21 -08:00
committed by GitHub
parent 52e257668d
commit 0881fd6397
11 changed files with 135 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/api/menu.md
View File

@@ -245,7 +245,7 @@ const template = [
submenu: [
{
label: 'Learn More',
click () { require('electron').shell.openExternal('https://electronjs.org') }
click () { require('electron').shell.openExternalSync('https://electronjs.org') }
}
]
}