github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

feat: split openExternal into sync and async (#16176)

Browse Source 
* feat: split openExternal into sync and async

* v8::Locker => mate::Locker

* fix: enter js env when resolving promise
This commit is contained in:
Shelley Vohr
2019-01-14 20:35:21 -08:00
committed by GitHub
parent 52e257668d
commit 0881fd6397
11 changed files with 135 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/tutorial/security.md
View File

@@ -639,7 +639,7 @@ app.on('web-contents-created', (event, contents) => {
// to open this event's url in the default browser.
event.preventDefault()
shell.openExternal(navigationUrl)
shell.openExternalSync(navigationUrl)
})
})
```