github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: fix ClientRequest.getUploadProgress (#21388)

Browse Source
This commit is contained in:
Jeremy Apthorp
2019-12-06 13:14:44 -08:00
committed by GitHub
parent dc9beda182
commit 092e00f7f0
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/browser/api/net.js
View File

@@ -454,7 +454,7 @@ class ClientRequest extends Writable {
}
getUploadProgress () {
return { ...this._uploadProgress } || { active: false }
return this._uploadProgress ? { ...this._uploadProgress } : { active: false }
}
}

11
spec-main/api-net-spec.ts
View File

@@ -1205,6 +1205,17 @@ describe('net module', () => {
})
})
it('should report upload progress', async () => {
const serverUrl = await respondOnce.toSingleURL((request, response) => {
response.end()
})
const netRequest = net.request({ url: serverUrl, method: 'POST' })
expect(netRequest.getUploadProgress()).to.deep.equal({ active: false })
netRequest.end(Buffer.from('hello'))
const [position, total] = await emittedOnce(netRequest, 'upload-progress')
expect(netRequest.getUploadProgress()).to.deep.equal({ active: true, started: true, current: position, total })
})
it('should emit error event on server socket destroy', async () => {
const serverUrl = await respondOnce.toSingleURL((request) => {
request.socket.destroy()