github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent crash in ListValue v8 converter when conversion fails (#22759)

Browse Source
This commit is contained in:
trop[bot]
2020-03-19 14:02:31 -07:00
committed by GitHub
parent 54e31956f8
commit 09ca564bf4
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/common/gin_converters/value_converter.cc
View File

@@ -59,7 +59,7 @@ bool Converter<base::ListValue>::FromV8(v8::Isolate* isolate,
electron::V8ValueConverter converter;
std::unique_ptr<base::Value> value(
converter.FromV8Value(val, isolate->GetCurrentContext()));
if (value->is_list()) {
if (value && value->is_list()) {
out->Swap(static_cast<base::ListValue*>(value.get()));
return true;
} else {