mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
fix: free IsolateData in ~NodeEnvironment (#28484)
This seems to just have been missing here, leaking memory (and breaking the API contract for Node.js embedding). Co-authored-by: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
@@ -286,7 +286,9 @@ void JavascriptEnvironment::OnMessageLoopDestroying() {
|
||||
NodeEnvironment::NodeEnvironment(node::Environment* env) : env_(env) {}
|
||||
|
||||
NodeEnvironment::~NodeEnvironment() {
|
||||
auto* isolate_data = env_->isolate_data();
|
||||
node::FreeEnvironment(env_);
|
||||
node::FreeIsolateData(isolate_data);
|
||||
}
|
||||
|
||||
} // namespace electron
|
||||
|
||||
Reference in New Issue
Block a user