fix: free IsolateData in ~NodeEnvironment (#28484)

This seems to just have been missing here, leaking memory
(and breaking the API contract for Node.js embedding).

Co-authored-by: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
trop[bot]
2021-04-06 08:55:02 +09:00
committed by GitHub
parent d76937f2b9
commit 0cba5d7a71

View File

@@ -286,7 +286,9 @@ void JavascriptEnvironment::OnMessageLoopDestroying() {
NodeEnvironment::NodeEnvironment(node::Environment* env) : env_(env) {}
NodeEnvironment::~NodeEnvironment() {
auto* isolate_data = env_->isolate_data();
node::FreeEnvironment(env_);
node::FreeIsolateData(isolate_data);
}
} // namespace electron