github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve ses.cookies.set error message when url is missing (#26268)

Browse Source
This commit is contained in:
Jeremy Rose
2020-11-02 02:00:29 -08:00
committed by GitHub
parent ecd23bb29b
commit 123e8d7038
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
shell/browser/api/electron_api_cookies.cc
View File

@@ -291,6 +291,9 @@ v8::Local<v8::Promise> Cookies::Set(v8::Isolate* isolate,
v8::Local<v8::Promise> handle = promise.GetHandle();
const std::string* url_string = details.FindStringKey("url");
if (!url_string) {
promise.RejectWithErrorMessage("Missing required option 'url'");
}
const std::string* name = details.FindStringKey("name");
const std::string* value = details.FindStringKey("value");
const std::string* domain = details.FindStringKey("domain");