github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Do not return TopLevelWindow in BrowserWindow.getAllWindows

Browse Source
This commit is contained in:
Cheng Zhao
2018-04-17 16:53:55 +09:00
parent e38f511737
commit 1340b17424
2 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
atom/browser/api/atom_api_browser_window.cc
View File

@@ -438,14 +438,8 @@ void Initialize(v8::Local<v8::Object> exports,
templ->InstanceTemplate()->SetInternalFieldCount(1);
BrowserWindow::BuildPrototype(isolate, templ);
mate::Dictionary browser_window(isolate, templ->GetFunction());
browser_window.SetMethod(
"fromId", &mate::TrackableObject<TopLevelWindow>::FromWeakMapID);
browser_window.SetMethod("getAllWindows",
&mate::TrackableObject<TopLevelWindow>::GetAll);
mate::Dictionary dict(isolate, exports);
dict.Set("BrowserWindow", browser_window);
dict.Set("BrowserWindow", templ->GetFunction());
}
} // namespace

13
lib/browser/api/browser-window.js
View File

@@ -128,6 +128,19 @@ BrowserWindow.prototype._init = function () {
})
}
const isBrowserWindow = (win) => {
return win && win.constructor.name === 'BrowserWindow'
}
BrowserWindow.fromId = (id) => {
const win = TopLevelWindow.fromId(id)
return isBrowserWindow(win) ? win : null
}
BrowserWindow.getAllWindows = () => {
return TopLevelWindow.getAllWindows().filter(isBrowserWindow)
}
BrowserWindow.getFocusedWindow = () => {
for (let window of BrowserWindow.getAllWindows()) {
if (window.isFocused() || window.isDevToolsFocused()) return window