github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-29 17:28:18 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: Lifetime of auth_info_ in login handler (#15042)

Browse Source
This commit is contained in:
Nitish Sakhawalkar
2018-10-09 16:50:44 -07:00
committed by Samuel Attard
parent 36ee83875a
commit 185fe6ced9
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
atom/browser/login_handler.cc
View File

@@ -25,7 +25,7 @@ LoginHandler::LoginHandler(
net::AuthCredentials* credentials,
const content::ResourceRequestInfo* resource_request_info)
: credentials_(credentials),
auth_info_(auth_info),
auth_info_(&auth_info),
auth_callback_(std::move(callback)),
weak_factory_(this) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);

4
atom/browser/login_handler.h
View File

@@ -40,7 +40,7 @@ class LoginHandler : public base::RefCountedThreadSafe<LoginHandler> {
// thread.
content::WebContents* GetWebContents() const;
const net::AuthChallengeInfo* auth_info() const { return &auth_info_; }
const net::AuthChallengeInfo* auth_info() const { return auth_info_.get(); }
private:
friend class base::RefCountedThreadSafe<LoginHandler>;
@@ -56,7 +56,7 @@ class LoginHandler : public base::RefCountedThreadSafe<LoginHandler> {
net::AuthCredentials* credentials_;
// Who/where/what asked for the authentication.
const net::AuthChallengeInfo& auth_info_;
scoped_refptr<const net::AuthChallengeInfo> auth_info_;
// WebContents associated with the login request.
content::ResourceRequestInfo::WebContentsGetter web_contents_getter_;