github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: cherry-pick 19a4eebd05a7 from devtools-frontend (#42103)

Browse Source
This commit is contained in:
Keeley Hammond
2024-05-09 08:01:12 -07:00
committed by GitHub
parent 196b6e66b8
commit 19d3d66f46
2 changed files with 99 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
patches/devtools-frontend/.patches
View File

@@ -1 +1,2 @@
cherry-pick-8a3bfd4b7403.patch
cherry-pick-19a4eebd05a7.patch

98
patches/devtools-frontend/cherry-pick-19a4eebd05a7.patch Normal file
View File

@@ -0,0 +1,98 @@
From 19a4eebd05a725daad9c254a342717f2ed203015 Mon Sep 17 00:00:00 2001
From: Andrey Kosyakov <caseq@chromium.org>
Date: Tue, 12 Mar 2024 19:58:44 -0700
Subject: [PATCH] Fix support for worklet targets
Bug: 327027138
Change-Id: I051565c591645f0a4ccc297825d299c0764501ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5367245
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
---
diff --git a/front_end/core/sdk/ChildTargetManager.ts b/front_end/core/sdk/ChildTargetManager.ts
index f2b6e42..895bdc7 100644
--- a/front_end/core/sdk/ChildTargetManager.ts
+++ b/front_end/core/sdk/ChildTargetManager.ts
@@ -172,6 +172,8 @@
type = Type.Frame;
} else if (targetInfo.type === 'worker') {
type = Type.Worker;
+ } else if (targetInfo.type === 'worklet') {
+ type = Type.Worklet;
} else if (targetInfo.type === 'shared_worker') {
type = Type.SharedWorker;
} else if (targetInfo.type === 'shared_storage_worklet') {
diff --git a/test/e2e/BUILD.gn b/test/e2e/BUILD.gn
index cac27fe..1e70e50 100644
--- a/test/e2e/BUILD.gn
+++ b/test/e2e/BUILD.gn
@@ -45,6 +45,7 @@
"settings",
"snippets",
"sources",
+ "targets",
"webaudio",
]
}
diff --git a/test/e2e/targets/BUILD.gn b/test/e2e/targets/BUILD.gn
new file mode 100644
index 0000000..d7e979b
--- /dev/null
+++ b/test/e2e/targets/BUILD.gn
@@ -0,0 +1,14 @@
+# Copyright 2020 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("../../../third_party/typescript/typescript.gni")
+
+node_ts_library("targets") {
+ sources = [ "worklet_test.ts" ]
+
+ deps = [
+ "../../shared",
+ "../helpers",
+ ]
+}
diff --git a/test/e2e/targets/worklet_test.ts b/test/e2e/targets/worklet_test.ts
new file mode 100644
index 0000000..9b8bfad
--- /dev/null
+++ b/test/e2e/targets/worklet_test.ts
@@ -0,0 +1,35 @@
+// Copyright 2024 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import {assert} from 'chai';
+
+import {
+ getBrowserAndPages,
+ goToResource,
+ waitForFunction,
+} from '../../shared/helper.js';
+import {describe, it} from '../../shared/mocha-extensions.js';
+import {
+ getStructuredConsoleMessages,
+ navigateToConsoleTab,
+} from '../helpers/console-helpers.js';
+
+describe('Audio worklet support', () => {
+ it('Receiving log messages from Audio worklets', async () => {
+ const {target} = getBrowserAndPages();
+ await goToResource('empty.html');
+ await navigateToConsoleTab();
+ await target.evaluate(() => {
+ const blob = new Blob(['console.log(\'hello from worklet\')'], {type: 'application/javascript'});
+ const url = URL.createObjectURL(blob);
+ const audioContext = new AudioContext();
+ return audioContext.audioWorklet.addModule(url);
+ });
+ const message = await waitForFunction(async () => {
+ const messages = await getStructuredConsoleMessages();
+ return messages[0];
+ });
+ assert.strictEqual(message.message, 'hello from worklet');
+ });
+});