github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-07 22:54:25 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: visibility state specs on macOS

Browse Source 
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5605407
This commit is contained in:
deepak1556
2024-06-12 17:55:16 +09:00
parent d9f9004ec3
commit 1eee30a33d
2 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
patches/chromium/.patches
View File

@@ -129,3 +129,4 @@ feat_add_support_for_missing_dialog_features_to_shell_dialogs.patch
fix_font_face_resolution_when_renderer_is_blocked.patch
feat_enable_passing_exit_code_on_service_process_crash.patch
chore_remove_reference_to_chrome_browser_themes.patch
fix_initial_occlusion_state_on_macos.patch

27
patches/chromium/fix_initial_occlusion_state_on_macos.patch Normal file
View File

@@ -0,0 +1,27 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: deepak1556 <hop2deep@gmail.com>
Date: Wed, 12 Jun 2024 17:42:07 +0900
Subject: fix: initial occlusion state on macOS
With the new occlusion detection enabled via
https://chromium-review.googlesource.com/c/chromium/src/+/5605407
starting the window as hidden previously resulted in
Visibility::kOccluded (via viewDidMoveToWindow) -> Visibility::kHidden (via viewDidHide)
but it now starts with Visibility::kVisible -> Visibility::kHidden
which throws off the initial document.visibilityState checks.
diff --git a/content/app_shim_remote_cocoa/web_contents_view_cocoa.mm b/content/app_shim_remote_cocoa/web_contents_view_cocoa.mm
index 58272aa6a046377c3eecbdeaa8b3901762443a85..eee76695006337d95ca6918411452bf1ca7f3f38 100644
--- a/content/app_shim_remote_cocoa/web_contents_view_cocoa.mm
+++ b/content/app_shim_remote_cocoa/web_contents_view_cocoa.mm
@@ -482,6 +482,10 @@ - (void)updateWebContentsVisibility {
visibility = Visibility::kHidden;
else if ([[self window] isOccluded])
visibility = Visibility::kOccluded;
+ else if ([[self window] occlusionState] & NSWindowOcclusionStateVisible)
+ visibility = Visibility::kVisible;
+ else
+ visibility = Visibility::kOccluded;
[self updateWebContentsVisibility:visibility];
}