github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: <webview> background transparency (#31727)

Browse Source 
Co-authored-by: Milan Burda <miburda@microsoft.com>
This commit is contained in:
trop[bot]
2021-11-05 20:09:30 -07:00
committed by GitHub
parent b763478ae5
commit 27fb917577
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
shell/browser/api/electron_api_web_contents.cc
View File

@@ -1401,14 +1401,15 @@ void WebContents::HandleNewRenderFrame(
&color_name)) {
web_contents()->SetPageBaseBackgroundColor(ParseHexColor(color_name));
} else {
web_contents()->SetPageBaseBackgroundColor(absl::nullopt);
web_contents()->SetPageBaseBackgroundColor(
IsGuest() ? absl::make_optional(SK_ColorTRANSPARENT) : absl::nullopt);
}
// When a page base background color is set, transparency needs to be
// explicitly set by calling
// RenderWidgetHostOwnerDelegate::SetBackgroundOpaque(false).
// RenderWidgetHostViewBase::SetBackgroundColor() will do this for us.
if (web_preferences->IsEnabled(options::kTransparent)) {
if (web_preferences->IsEnabled(options::kTransparent) || IsGuest()) {
rwhv->SetBackgroundColor(SK_ColorTRANSPARENT);
}
}