github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: sync IsKillURL() with upstream impl in extension_tab_util.cc (#47595)

Browse Source 
Use base::MakeFixedFlatSet()

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot]
2025-06-30 11:17:04 +02:00
committed by GitHub
parent abba008673
commit 2856008e52
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
shell/browser/extensions/api/tabs/tabs_api.cc
View File

@@ -11,7 +11,7 @@
#include <vector>
#include "base/command_line.h"
#include "base/containers/contains.h"
#include "base/containers/fixed_flat_set.h"
#include "base/strings/pattern.h"
#include "base/types/expected_macros.h"
#include "chrome/common/url_constants.h"
@@ -497,13 +497,16 @@ bool IsKillURL(const GURL& url) {
}
// Also disallow a few more hosts which are not covered by the check above.
static const char* const kKillHosts[] = {
chrome::kChromeUIDelayedHangUIHost, chrome::kChromeUIHangUIHost,
chrome::kChromeUIQuitHost, chrome::kChromeUIRestartHost,
content::kChromeUIBrowserCrashHost, content::kChromeUIMemoryExhaustHost,
};
constexpr auto kKillHosts = base::MakeFixedFlatSet<std::string_view>({
chrome::kChromeUIDelayedHangUIHost,
chrome::kChromeUIHangUIHost,
chrome::kChromeUIQuitHost,
chrome::kChromeUIRestartHost,
content::kChromeUIBrowserCrashHost,
content::kChromeUIMemoryExhaustHost,
});
return base::Contains(kKillHosts, url.host_piece());
return kKillHosts.contains(url.host_piece());
}
GURL ResolvePossiblyRelativeURL(const std::string& url_string,