github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-05-02 03:00:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(patch): trace builtin num_args renamed to has_arg

Browse Source 
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7775556

Co-Authored-By: GitHub Copilot (Claude Opus 4.6)
This commit is contained in:
Charles Kerr
2026-05-01 20:49:22 -05:00
parent 10562a5f49
commit 29315fc729
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
patches/v8/src_use_legacy_trace_macros_in_perfetto_to_support_all_phases.patch
View File

@@ -22,10 +22,10 @@ Additionally:
invisible in trace viewers.
diff --git a/src/builtins/builtins-trace.cc b/src/builtins/builtins-trace.cc
index c17d72d477d4c28d25e3f385d8af3c5b7024f7f7..5990e6cee1d08ba0e86059cb7f3affc878dcc632 100644
index 76e9675d795bd6f65ec1b9c8a524b713160de7cc..ee0967847236b665d2e61b90128c6b4e79b74ea8 100644
--- a/src/builtins/builtins-trace.cc
+++ b/src/builtins/builtins-trace.cc
@@ -181,37 +181,44 @@ BUILTIN(Trace) {
@@ -183,37 +183,44 @@ BUILTIN(Trace) {
}
#if defined(V8_USE_PERFETTO)
@@ -49,7 +49,7 @@ index c17d72d477d4c28d25e3f385d8af3c5b7024f7f7..5990e6cee1d08ba0e86059cb7f3affc8
+ // Use the legacy trace event macros which support all phase types
+ // (including nestable async 'b'/'e'/'n' and counter 'C' used by Node.js)
+ if (flags & TRACE_EVENT_FLAG_HAS_ID) {
if (num_args) {
if (has_arg) {
MaybeUtf8 arg_contents(isolate, Cast<String>(arg_json));
- auto annotation = ctx.event()->add_debug_annotations();
- annotation->set_name(arg_name);
@@ -65,7 +65,7 @@ index c17d72d477d4c28d25e3f385d8af3c5b7024f7f7..5990e6cee1d08ba0e86059cb7f3affc8
- auto legacy_event = ctx.event()->set_legacy_event();
- legacy_event->set_global_id(id);
+ } else {
+ if (num_args) {
+ if (has_arg) {
+ MaybeUtf8 arg_contents(isolate, Cast<String>(arg_json));
+ INTERNAL_TRACE_EVENT_ADD(
+ phase, dynamic_category, perfetto::DynamicString(*name), flags,