github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-26 07:48:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove unneeded check but document why it is not there now

Browse Source
This commit is contained in:
Samuel Attard
2017-07-31 10:47:25 +10:00
parent 3ac2f674bc
commit 32327b77a5
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
atom/browser/atom_browser_client.cc
View File

@@ -120,9 +120,12 @@ bool AtomBrowserClient::ShouldCreateNewSiteInstance(
// reuse the same site to allow cross-window scripting. We do
// not need to check urls / domains as native window open logic
// handles cross site scripting protection.
if (WebContentsPreferences::UsesNativeWindowOpen(web_contents)) {
return false;
}
//
// NOTE: We know that nativeWindowOpen is enabled at this point
// because we check if it is NOT enabled above this point. We
// will only reach this return if sanbox is disabled but
// nativeWindowOpen is enabled.
return false;
}
// Create new a SiteInstance if navigating to a different site.