github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove constexpr from KeyboardCodeFromKeyIdentifier

Browse Source 
Ref: unknown

Added TODO to investigate after
This commit is contained in:
Samuel Attard
2024-06-27 13:02:25 -07:00
parent d94601a13e
commit 394a26f94a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shell/common/keyboard_util.cc
View File

@@ -16,8 +16,8 @@ namespace {
using CodeAndShiftedChar = std::pair<ui::KeyboardCode, std::optional<char16_t>>;
constexpr CodeAndShiftedChar KeyboardCodeFromKeyIdentifier(
const std::string_view str) {
// TODO: Why does making this constexpr fail
CodeAndShiftedChar KeyboardCodeFromKeyIdentifier(const std::string_view str) {
#if BUILDFLAG(IS_MAC)
constexpr auto CommandOrControl = ui::VKEY_COMMAND;
#else